MLCOMPUTE-1224 | add aws default region to prevent botocore.exceptions.NoRegionError #3857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
reviewed
May 9, 2024
| @@ -442,6 +442,7 @@ def get_env( | |||
| env = super().get_env(system_paasta_config=system_paasta_config) | |||
|
|
|||
| if self.get_executor() == "spark": | |||
| env["AWS_DEFAULT_REGION"] = DEFAULT_AWS_REGION | |||
There was a problem hiding this comment.
a comment about why this necessary would be useful for future yelpers :)
chi-yelp
approved these changes
May 9, 2024
added 3 commits
May 9, 2024 17:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boto3 client complains with NoRegionError if there is no default region specified. https://fluffy.yelpcorp.com/i/zBXdRwX6FxszthrZLm6FVnWp8L4rjmzJ.html#L309-310
Replicating the behaviour in paasta spark-run, adding the AWS_DEFAULT_REGION env variable for jobs with Spark drivers on k8s