Bump service-configuration-lib to 2.18.22 to reduce logspam + IO #3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version printed out a log line for every volume that did not exist on the host running a spark config getter - but that's not necessarily an error as the set of files on a kube node do not always match those on boxes where s-c-l is being invoked from
nemacysts
requested review from
jfongatyelp,
88manpreet,
ankit864 and
CaptainSame
jfongatyelp
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version printed out a log line for every volume that did not exist on the host running a spark config getter - but that's not necessarily an error as the set of files on a kube node do not always match those on boxes where s-c-l is being invoked from