ebook reader doesn't save anything #44

illumina7 · 2017-04-12T14:14:57Z

Hello,
I'm using the ebook reader app 1.0.4 on my private nextcloud 11 server (latest stable build on ubuntu server 14.04).
It can read the ebooks without any issue and i can save bookmarks and annotations, but after closing and reopening an ebook all saves are gone. The reader isn't saving the last reading postion too and I need to search for my last opened page every time I want to continue reading.
Is this a common issue or is there just something wrong with my nextcloud installation?
Greetings from Germany!

jryberg · 2017-05-07T14:17:00Z

Hi,

I got the exact same issue

The only logs I have are this event every time I open the document:

{"reqId":"[REDACTED]","remoteAddr":"[REDACTED]","app":"PHP","message":"Undefined` index: title at /var/www/nextcloud/apps/files_reader/templates/epubreader.php#37","level":3,"time":"2017-05-07T14:24:39+00:00","method":"GET","url":"/index.php/apps/files_reader/?file=%2Fremote.php%2Fwebdav%2FDocuments%2FE-books%2F[REDACTED].epub&type=application%2Fepub%2Bzip","user":"[REDACTED]","version":"11.0.2.7"}

Yetangitu · 2017-05-07T22:20:55Z

Which database do you use?

jryberg · 2017-05-08T07:46:58Z

Hi,

MySQL: 5.7.18

Ubuntu 16.04.2 LTS
PHP: 7.0.15-0ubuntu0.16.04.4

Best regards Johan

illumina7 · 2017-05-08T08:54:07Z

Hello again,
I'am currently using:

Ubuntu Server 16.04.02 LTS (seems like I've been looking for the wrong VM last time)
Nextcloud: 11.0.3 stable
MySQL: 5.7.18
PHP: 7.0.15-0ubuntu0.16.04.04

This server is virtualized with virtualbox and I am using an apache reverse proxy with a ssl cert from letsencrypt.org sitting behind an ipfire firewall.

I've searched the Logs and find the same Error Log as @jryberg "Undefined index: title at /var/www/nextcloud/apps/files_reader/templates/epubreader.php#37".

Best regards

Yetangitu · 2017-05-08T22:45:01Z

I'll look into this when I have some time to dedicate to these apps...

scurrvy2020 · 2017-06-17T10:12:14Z

Same issue here.
Ubuntu 16.04.2
MySQL: 5.7.18
PHP: 7.0.15

Yetangitu · 2017-06-17T23:17:39Z

OK, this seems to be a real issue so I'll just have to find some time. Stay tuned but don't hold your breath...

scurrvy2020 · 2017-06-22T13:14:05Z

I did a little investigation... the oc_reader_bookmarks and oc_reader_preferences tables are created, but they are empty.

LearnLinuxTV · 2017-06-23T19:34:33Z

Same issue here.

ghost · 2017-07-23T08:57:01Z

Same issue here.
Ubuntu Server 16.04.2
MMySQL 5.7.19
PHP 7.0.18
I can read eBooks very well, but nothing is saved.

mysql> select * from oc_reader_preferences;
Empty set (0,00 sec)

mysql> select * from oc_reader_bookmarks;
Empty set (0,00 sec)

scurrvy2020 · 2017-08-19T11:06:45Z

Is there anything we can do to help you debug this?
I really miss having this functionality.

mpodshivalin · 2017-10-07T00:53:18Z

When changing preferences/adding bookmarks/switching pages, the app does POST-requests to save data, but they result in 404 error (routing doesn't work correctly):

mpodshivalin · 2017-10-07T14:50:16Z

I've just tried to reproduce this on a clean VM with ownCloud 10.0.3 (the app can only be installed manually because its maximum ownCloud version is set to 9.2). The app works exactly as in Nextcloud 12.0.3 - reading works, but saving data doesn't.

mpodshivalin · 2017-10-11T19:42:38Z

I've managed to make a temporary fix for this issue.

Go to your Nextcloud/ownCloud installation location
Open /apps/files_reader/js/ready.js
Find this line

options.session.basePath = $session.data('basepath');

Change this line to

options.session.basePath = '<your Nextcloud/ownCloud server URL>/index.php/apps/files_reader/';

Clear your web browser cache

After this, bookmarks, settings and navigation work, are saved and restored when opening the document.

The proper way to do this without hardcoding the URL would be to use official JS API, but I'm too inexperienced in making ownCloud/Nextcloud apps :)

Yetangitu · 2017-10-11T20:03:42Z

Good catch, I'll look into this ASAP

Yetangitu · 2017-10-11T23:18:59Z

The issue is caused by mismatched quoting in the templates (files_reader/templates/epubreader.php and files_reader/templates/cbreader.php) and can be fixed by changing the single quotes inside the data-basepath declaration to double quotes, like so:

data-basepath='<?php p($urlGenerator->linkTo("files_reader",""));?>'

I'll release a new version tomorrow which fixes this and adds PDF support. The PDF renderer is ready, the UI is more or less ready, only the position saving bits have not been wired up yet. That'll come soon enough...

scurrvy2020 · 2017-10-12T11:40:50Z

Thanks!

scurrvy2020 · 2017-10-12T13:20:41Z

hmmm. I changed the quotes in the line as you mentioned, rebooted the server, but I am still not able to save anything. Anyway, I'll wait for your updated app. Thanks!

mpodshivalin · 2017-10-12T13:39:57Z

scurrvy2020, maybe the problem is that there are two templates in files_reader/templates: cbreader.php and epubreader.php. Try Yetangitu's changes with both of these files.

Yetangitu, thanks again for the app! PDF support will be a great addition. And position saving will be a killer feature, since ownCloud/Nextcloud's PDF viewer doesn't support it.

Yetangitu · 2017-10-12T16:50:38Z

Change both templates to make sure you changed the correct one.

The PDF reader does not support position saving yet but that will come. It does support 2-page spreads though:

LearnLinuxTV · 2017-10-12T17:34:13Z

I manually changed the referenced code to double quotes in both template files, and that did not fix it for me. I am unsure if I needed to make that change in other places in the same file.

…

Sent from my iPhone

On Oct 12, 2017, at 12:50 PM, Frank de Lange ***@***.***> wrote: Change both templates to make sure you changed the correct one. The PDF reader does not support position saving yet but that will come. It does support 2-page spreads though: — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Yetangitu · 2017-10-12T17:53:31Z

Do you get any error messages in the javascript console (use 'inspect' to show the console, make sure it is set to show all messages)?

Did you restart the PHP container service (php-fpm, mod-php or whatever you use)? Sometimes it does not seem to pick up changes until after it has been restarted, even though it should 'just work'.

LearnLinuxTV · 2017-10-12T18:12:12Z

It’s saying: POST <nextcloud_url>/apps/files_reader/bookmark 404 (Not Found)

…

Sent from my iPhone

On Oct 12, 2017, at 1:53 PM, Frank de Lange ***@***.***> wrote: Do you get any error messages in the javascript console (use 'inspect' to show the console, make sure it is set to show all messages)? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

mpodshivalin · 2017-10-12T18:27:17Z

For some reason, in my case

p($urlGenerator->linkTo("files_reader",""));

returns /nextcloud/apps/files_reader/. This is the query that returns 404 error.

In my example above, I've hardcoded /nextcloud/index.php/apps/files_reader/. This query works.

Yetangitu · 2017-10-12T18:48:51Z

urlGenerator should return the correct URL (with or without index.php depending on whether you use rewrite rules to create 'pretty' URLs). The code lives in lib/private/urlGenerator.php in the OC/NC root, it uses the boolean $frontControllerActive to switch between 'pretty' and normal URLs:

$frontControllerActive = ($this->config->getSystemValue('htaccess.IgnoreFrontController', false) === true || getenv('front_controller_active') === 'true');

...

$urlLinkTo = \OC::$WEBROOT . '/index.php/apps/' . $app;
if ($frontControllerActive) {
    $urlLinkTo = \OC::$WEBROOT . '/apps/' . $app;
}

If you get 'wrong' URLs it might be that you've got one of those parameters (htaccess.IgnoreFrontController or front_controller_active) wrongly set.

mpodshivalin · 2017-10-12T21:39:06Z

For some weird reason (in my case) pdfreader makes requests to URLs with index.php, while files_reader makes requests to URLs without index.php. I've even downloaded clean Bitnami ownCloud VM and got the same results. I've made a fix for myself and everything works fine, but I'm afraid others will be affected by this issue.

Maybe the reason why pdfreader works is because it generates PHP URLs in PHP urlGenerator and JS URLs in JavaScript's OC.generateUrl?

You're definitely right that OC/NC's urlGenerator should return correct URLs, so it's not plugin's fault.

scurrvy2020 · 2017-10-13T11:41:26Z

mpodshivalin, I've tried adding the url with index.php to the ready.js file, but it still doesn't work :-/

I'm still getting 404 errors. I've rebooted the server as well. If I edit the message and add "index.php" to the referrer url, the message will successfully post.

Did you do anything else to hardcode the index.php into the url?

mpodshivalin · 2017-10-13T12:31:37Z

Did you clear your web browser's cache after editing ready.js file?

scurrvy2020 · 2017-10-13T12:53:47Z

yes, cleared the cache, tried different browsers, different computers. nothing worked

Yetangitu · 2017-10-13T13:28:09Z

The Javascript-version of the urlgenerator (OC.generateUrl in core/js/js.js) takes a different path to decide whether or not to add index.php to the generated URL:

        if(oc_config.modRewriteWorking == true) {
            return OC.webroot + _build(url, params);
        }

        return OC.webroot + '/index.php' + _build(url, params);

...where oc_config.modRewriteWorking is populated (in /lib/private/Template/JSConfigHelper.php) as:

'modRewriteWorking' => (\OC::$server->getConfig()->getSystemValue('htaccess.IgnoreFrontController', false) === true || getenv('front_controller_active') === 'true')

The path taken is different but the logic used is similar.

You can view the contents of oc_config by requesting <OC_NC_ROOT>/core/js/oc.js using a GET request (i.e. just use a browser), the result looks somewhat like this:

...
var oc_config={"session_lifetime":1440,"session_keepalive":true,"version":"11.0.2.7","versionstring":"11.0.2","enable_avatars":true,"lost_password_link":null,"modRewriteWorking":true};
...

Look for the value of modRewriteWorking, if this is true the Javascript version (OC.generateUrl) does not add index.php to the generated URL. If the PHP version acts differently something is amiss, somewhere. The question remains, where? I could just use the Javascript version but that would be a cop-out. I'll dig some deeper.

scurrvy2020 · 2017-10-13T13:47:21Z

I had to go to domain/nextcloud/index.php/core/js/oc.js to get the output in the browser

var oc_config={"session_lifetime":1440,"session_keepalive":true,"version":"12.0.3.3","versionstring":"12.0.3","enable_avatars":true,"lost_password_link":null,"modRewriteWorking":false,"sharing.maxAutocompleteResults":0,"sharing.minSearchStringLength":0,"blacklist_files_regex":"\\.(part|filepart)$"};

looks like mine is false...

scurrvy2020 · 2017-10-14T04:16:31Z

I added these two lines to my config.php and used sudo -u www-data php occ maintenance:update:htaccess to regenerate the .htaccess file.

  'htaccess.IgnoreFrontController' => true,
  'htaccess.RewriteBase' => '/nextcloud',

After rebooting the server and clearing the browser cache I am now able to save items in the reader app. However, there are some icons in the header of nextcloud that are giving error 404. (update: disabling the theming app fixes the icons, there is a known bug with theming and rewrite: https://help.nextcloud.com/t/icons-missing-path-not-rewritten/4722/18)
So, it looks like rewrite was not properly detected by nextcloud, correct?

Yetangitu · 2017-10-20T21:09:19Z

I don't use htaccess myself, using nginx with php-fpm. As such I do not track the routines around updating that file but the mere presence of that command in occ does make me think this step is mandatory to get the file to be updated.

LearnLinuxTV · 2018-01-18T18:07:23Z

A new version was released today, but unfortunately, this issue still remains. :(

Yetangitu · 2018-01-18T20:30:46Z

Same messages in the console?

I mean this one: POST <nextcloud_url>/apps/files_reader/bookmark 404 (Not Found)

Does the link work if you include index.php before /apps?

LearnLinuxTV · 2018-01-18T20:50:14Z

I see this:

POST https://nextcloud.mydomain.net/apps/files_reader/bookmark 404 (Not Found)
send @ jquery.min.js?v=1.1.0.0071:4
ajax @ jquery.min.js?v=1.1.0.0071:4
n.(anonymous function) @ jquery.min.js?v=1.1.0.0071:4
options.session.setBookmark @ ready.js?v=1.1.0.0071:65
EPUBJS.Reader.addAnnotation @ reader.min.js?v=1.1.0.0071:1
EPUBJS.Reader.addBookmark @ reader.min.js?v=1.1.0.0071:1
(anonymous) @ reader.min.js?v=1.1.0.0071:1
dispatch @ jquery.min.js?v=1.1.0.0071:3
r.handle @ jquery.min.js?v=1.1.0.0071:3
jquery.min.js?v=1.1.0.0071:4 DELETE https://nextcloud.mydomain.net/apps/files_reader/bookmark/1171/epubcfi62cover4page10 405 (Method Not Allowed)

As far as including index.php before /apps, how would I do that? Is there a file I would edit somewhere to add that?

Thanks!

Yetangitu · 2018-01-22T17:20:07Z

Try the following query in a browser in which you're logged in to your instance of NC:

https://nextcloud.mydomain.net/apps/files_reader/bookmark/cursor/1171

This should produce a JSON response containing the last visited location in that publication, like so:

{"name":"__CURSOR__","type":"bookmark","value":14,"content":null,"lastModified":"1516640984881243"}

I got the file_id (1171 in the url) from your previous response so I assume a file with that id exists on your instance. If there is no cursor set it will give a null reply. If the query redirects to the NC front page there is something wrong with your install. In that case try the following query:

https://nextcloud.mydomain.net/index.php/apps/files_reader/bookmark/cursor/1171

If that query works (i.e. you get either a JSON or null response) there is something wrong with the URL rewrite logic.

LearnLinuxTV · 2018-01-29T16:09:21Z

For some reason my reply shows before yours. The first link doesn't work but the second one does. You mentioned that there may be something wrong with the rewrite logic, can you please elaborate more?

Yetangitu · 2018-01-29T23:15:30Z

Which webserver do you use? The rewrite rules for Apache are kept in the .htaccess file in the NC root directory, this file can be updated using occ maintenance:update:htaccess but as I do not use Apache I can not vow for the efficacy of this command. If you use nginx (like I do) you should have configured the rewrite rules in your site directory (e.g. /etc/nginx/sites-enabled/your_site_name or something similar, see https://docs.nextcloud.com/server/12/admin_manual/installation/nginx.html for more information and examples.

LearnLinuxTV · 2018-01-30T18:50:14Z

This server is using Apache. The .htaccess file is default, I've made no changes to it. I have read the documentation regarding Apache, and it mentions to make sure that the .htaccess file is writable by the Apache user (it is), that mod env and rewrite are enabled (they are) and config.php has:
'overwrite.cli.url' => 'https://nextcloud.mydomain.net'

From an Apache perspective, everything seems fine according to the documentation. Perhaps there's an issue with the .htaccess file that ships with Nextcloud and I need to file a bug against it?

Thanks!

LearnLinuxTV · 2018-02-01T04:39:10Z

This is resolved for me. I fixed it by getting "pretty urls" to work with Apache following the documentation. I didn't really understand what you guys were referring to with the different URLs but now I understand it.

However, my thought process right now is why does this app require pretty urls? Why can't it work without it? All the other apps I've used with Nextcloud all work perfectly fine right out of the box but for some reason this one doesn't.

I'm glad it's working now, though. Thank you all for your assistance.

Yetangitu · 2018-02-01T06:19:27Z

Reader does not require 'pretty URLs', it works just fine with ugly ones as well (which I used myself until recently). The way Reader works probably makes it more sensitive to problems in the rewrite logic, it is implemented as a plugin to the Files app and uses it in the background to download publications to show in the browser.

Yetangitu · 2018-02-25T23:20:03Z

Closing this as all known problems in Reader seem to be resolved; problems caused by faulty rewrite logic lie outside of the scope of this bug tracker.

fogcake · 2018-07-09T15:40:11Z

Hello,

I am struggling to make the history and bookmarks working for files_reader.

I am using nginx, so I followed these guide to add rewrite rules:
https://doc.owncloud.org/server/9.1/admin_manual/installation/nginx_examples.html

I am having exactly the same problems with POST queries getting 404 as an answer. So both oc_reader_bookmarks and oc_reader_preferences tables are not populated.

Any hints will be very appreciated.

Best regards,
Andriy
UPDATE: Fixed by hardcoding url as @mpodshivalin suggested.

xenithorb mentioned this issue Feb 24, 2018

New CSP issue? #81

Closed

Yetangitu closed this as completed Feb 25, 2018

scurrvy2020 mentioned this issue Nov 21, 2018

Bookmark are not stored for next sessions/readings #104

Open

intari mentioned this issue Dec 14, 2020

Bookmarks and comments were not saved e-alfred/epubreader#10

Open

ebook reader doesn't save anything #44

ebook reader doesn't save anything #44

Comments

illumina7 commented Apr 12, 2017

jryberg commented May 7, 2017 • edited Loading

Yetangitu commented May 7, 2017

jryberg commented May 8, 2017

illumina7 commented May 8, 2017

Yetangitu commented May 8, 2017

scurrvy2020 commented Jun 17, 2017

Yetangitu commented Jun 17, 2017

scurrvy2020 commented Jun 22, 2017

LearnLinuxTV commented Jun 23, 2017

ghost commented Jul 23, 2017

scurrvy2020 commented Aug 19, 2017

mpodshivalin commented Oct 7, 2017

mpodshivalin commented Oct 7, 2017

mpodshivalin commented Oct 11, 2017 • edited Loading

Yetangitu commented Oct 11, 2017

Yetangitu commented Oct 11, 2017

scurrvy2020 commented Oct 12, 2017

scurrvy2020 commented Oct 12, 2017

mpodshivalin commented Oct 12, 2017

Yetangitu commented Oct 12, 2017

LearnLinuxTV commented Oct 12, 2017 via email

Yetangitu commented Oct 12, 2017 • edited Loading

LearnLinuxTV commented Oct 12, 2017 via email

mpodshivalin commented Oct 12, 2017

Yetangitu commented Oct 12, 2017 • edited Loading

mpodshivalin commented Oct 12, 2017

scurrvy2020 commented Oct 13, 2017

mpodshivalin commented Oct 13, 2017

scurrvy2020 commented Oct 13, 2017

Yetangitu commented Oct 13, 2017

scurrvy2020 commented Oct 13, 2017 • edited Loading

scurrvy2020 commented Oct 14, 2017 • edited Loading

Yetangitu commented Oct 20, 2017

LearnLinuxTV commented Jan 18, 2018

Yetangitu commented Jan 18, 2018

LearnLinuxTV commented Jan 18, 2018

Yetangitu commented Jan 22, 2018

LearnLinuxTV commented Jan 29, 2018

Yetangitu commented Jan 29, 2018

LearnLinuxTV commented Jan 30, 2018

LearnLinuxTV commented Feb 1, 2018 • edited Loading

Yetangitu commented Feb 1, 2018

Yetangitu commented Feb 25, 2018

fogcake commented Jul 9, 2018 • edited Loading

jryberg commented May 7, 2017 •

edited

Loading

mpodshivalin commented Oct 11, 2017 •

edited

Loading

Yetangitu commented Oct 12, 2017 •

edited

Loading

Yetangitu commented Oct 12, 2017 •

edited

Loading

scurrvy2020 commented Oct 13, 2017 •

edited

Loading

scurrvy2020 commented Oct 14, 2017 •

edited

Loading

LearnLinuxTV commented Feb 1, 2018 •

edited

Loading

fogcake commented Jul 9, 2018 •

edited

Loading