Pass $post_id in all WPSEO_Meta::get_value calls in metabox - fixes #1519 #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 31, 2014 10:00
The post is fetched by checking for $_GET['post_id'] or using the global $post as a fallback. This was repeated multiple times in the class, so a single method makes sense.
mgmartel
force-pushed
the
metabox-post-id
branch
from
cb43fe6
to
c6edb61
Compare
|
Nice! Even though I'm quite against building work-around for bugs introduced by other plugins which are doing things wrong, I think in this case the solution is elegant and simple enough. You have my vote. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If another plugin overwrites the global $post in
post.php, the SEO metabox displays the metadata from the wrong post, and consequently saves the wrong data to the right post, leading to the strange behaviour of #1519.WP SEO already fetched the correct post by checking for
$_GET['post']first, but didn't pass this post on inWPSEO_Meta::get_valuecalls. Allget_valuecalls in the metabox now get the post ID as well. The check for$_GET['post']was happening quite often in the class, so I also abstracted that into the private methodWPSEO_Metabox::get_metabox_post().