Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if element with ID 'content' exists before attempting to retrieve its value (Fix #3395) #3404

Closed
wants to merge 2 commits into from

Conversation

aaronhipple
Copy link
Contributor

Fixes JavaScript error on post types without 'editor' capability.

@Rarst
Copy link
Contributor

Rarst commented Nov 23, 2015

Could you please fix up whitespace so that build passes? :) See https://travis-ci.org/Yoast/wordpress-seo/jobs/92360743#L700-L718

@aaronhipple
Copy link
Contributor Author

Thanks @Rarst -- Saw that on Friday but it's been a little hectic for the holidays. Passing now. :)

@codeforest
Copy link

We tested and confirmed that this is working as expected now when no content div is present on the screen!

Please merge this and release it when you see fit.

Thanks @aaronhipple for contributing...

@omarreiss
Copy link
Contributor

@aaronhipple thanks a lot for your contribution! The same issue was also fixed in #3363 amongst other issues. This was already merged and will be released today. I did however merge your commits into 3.0.4 branch (6eaaa88) as well to credit your contribution and make sure you will end up in the list of contributors! Thanks @codeforest for testing! I will mention you guys in the changelog as well.

@omarreiss omarreiss closed this Nov 25, 2015
@omarreiss omarreiss added this to the 3.0.4 milestone Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants