-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version 1.2.0 #67
Commits on Dec 19, 2022
-
GH Actions: minor simplification
... of the bash `date` command in the earlier pulled cache busting.
Configuration menu - View commit details
-
Copy full SHA for 16eb1a8 - Browse repository at this point
Copy the full SHA 16eb1a8View commit details -
GH Actions: improve performance of the CS step
All the repos in the Yoast organisation contain a `<arg name="cache" value="./.cache/phpcs.cache"/>` directive in the PHPCS ruleset. This directive makes running PHPCS faster by caching the run results in a file and only scanning changed files when running PHPCS again. However, when there is no cache available, running with the `cache` option enabled will make PHPCS _slower_ as the cache needs to be created and the file read/write actions slow PHPCS down. In GH Actions, we are not caching the PHPCS `cache` file, which means that there is cache file available and running with `cache` will be slower. By adding the `--no-cache` option, the `cache` directive in the ruleset is ignored, which should result in a slightly faster runtime for the CS workflow. Note: the alternative would be to _cache_ the cache file in GH Actions, but aside from the two very frequently changing repos, there's not much point doing that.
Configuration menu - View commit details
-
Copy full SHA for ca588d6 - Browse repository at this point
Copy the full SHA ca588d6View commit details -
GH Actions: enable linting and testing against PHP 8.3
While early days for PHP 8.3, as this is a test related package, it needs to be ready early, so better to start running the lint and test workflows against PHP 8.3 already.
Configuration menu - View commit details
-
Copy full SHA for 5996652 - Browse repository at this point
Copy the full SHA 5996652View commit details -
Merge pull request #48 from Yoast/feature/ghactions-tweaks
GH Actions: various tweaks
Configuration menu - View commit details
-
Copy full SHA for 12287f2 - Browse repository at this point
Copy the full SHA 12287f2View commit details
Commits on Jan 9, 2023
-
Composer: update YoastCS and dependencies
* YoastCS 2.3.0 has been released. Previous version used was `2.2.1`. Ref: https://github.com/Yoast/yoastcs/releases/tag/2.3.0 * Version 1.0.0 of the Composer PHPCS plugin has been released. Previous version used was `0.7.2`. Ref: https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases
Configuration menu - View commit details
-
Copy full SHA for 65e3ffd - Browse repository at this point
Copy the full SHA 65e3ffdView commit details -
Merge pull request #49 from Yoast/JRF/update-yoastcs-dependencies
Composer: update YoastCS and dependencies
Configuration menu - View commit details
-
Copy full SHA for b194794 - Browse repository at this point
Copy the full SHA b194794View commit details
Commits on May 1, 2023
-
CI/QA: start recording code coverage
This commit make the necessary changes to start recording and uploading code coverage data to Coveralls. Includes: * Updating the GH Actions `test` worflow to run the high/low PHP version builds with code coverage and upload the results. * Updating the PHPUnit config to show an inline code coverage summary and improve the `filter` configuration. * Adding a code coverage badge to the README. Not included as already in place: * Ignoring the potentially generated code coverage files in the `build/*` directory to prevent it being committed. * Adding a script to the `composer.json` file to run code coverage. Notes: * Coverage will be recorded using `Xdebug` as the code coverage driver. * The `php-coveralls/php-coveralls` package is used to convert the coverage information from a format as generated by PHPUnit to a format as can be consumed by Coveralls. - As this package is only needed for the upload to Coveralls, the package has **not** been added it to the `composer.json` file, but will be (global) installed in the GH Actions workflow only. - The `php-coveralls/php-coveralls` package is not 100% compatible with PHP 8.x (yet), so for uploading the coverage generated using PHP 8.x, we switch to PHP 7.4 for uploading the code coverage reports. * Coveralls requires a token to identify the repo and prevent unauthorized uploads. This token has been added to the repository secrets. People with admin access to the GH repo automatically also have access to the admin settings in Coveralls. If ever needed, the Coveralls token can be found (and regenerated) in the Coveralls admin for a repo. After regeneration, the token as stored in the GH repo Settings -> Secrets and Variables -> Actions -> Repository secrets should be updated. * As the workflow sends multiple code coverage reports to Coveralls, we need to tell it to process those reports in parallel and give each report a unique name. That's what the `COVERALLS_PARALLEL` and COVERALLS_FLAG_NAME` settings are about. * The `coveralls-finish` job will signal to Coveralls that all reports have been uploaded. This basically gives the "okay" to Coveralls to report on the changes in code coverage via a comment on a GitHub PR as well as via a status check. The pertinent Coveralls settings used for this repo are: * "Only send aggregate Coverage updates to SCM": enabled * "Leave comments": enabled * "(Comment) Format": compact * "Use Status API": enabled * "Coverage threshold for failure": 95% * "Coverage decrease threshold for failure": 1.0%
Configuration menu - View commit details
-
Copy full SHA for b4d180a - Browse repository at this point
Copy the full SHA b4d180aView commit details -
Merge pull request #50 from Yoast/JRF/start-recording-code-coverage
CI/QA: start recording code coverage
Configuration menu - View commit details
-
Copy full SHA for 7da5034 - Browse repository at this point
Copy the full SHA 7da5034View commit details -
Dependabot: add reviewer config
The Dependabot PRs can have a tendency to stay open for a long time, while for the GH Actions and Composer dependency related ones I keep an eye on all used action runner releases anyway. However, I don't "watch" all Yoast repos, so adding this configuration will ensure that I get notified about Dependabot PRs for this repo (and can merge it if appropriate or close it otherwise).
Configuration menu - View commit details
-
Copy full SHA for 22aaa65 - Browse repository at this point
Copy the full SHA 22aaa65View commit details -
* PHPUnit Polyfills 1.0.5 has been released. Ref: https://github.com/Yoast/PHPUnit-Polyfills/releases/tag/1.0.5 * YoastCS 2.3.1 has been released. Ref: https://github.com/Yoast/yoastcs/releases/tag/2.3.1
Configuration menu - View commit details
-
Copy full SHA for 0ca5f3a - Browse repository at this point
Copy the full SHA 0ca5f3aView commit details -
BrainMonkey/YoastTestCase: rename parameter for mocked function
... as WP Core has renamed the parameter as part of the efforts to become compatible with PHP 8.0. Ref: WordPress/wordpress-develop@51fae8b
Configuration menu - View commit details
-
Copy full SHA for 8a2874b - Browse repository at this point
Copy the full SHA 8a2874bView commit details -
BrainMonkey/YoastTestCase: rename parameter for mocked function
... to be in line with the parameter name as used by WP Core for optimal compatibility with PHP 8.0. Ref: https://developer.wordpress.org/reference/functions/wp_parse_args/
Configuration menu - View commit details
-
Copy full SHA for 6f76e88 - Browse repository at this point
Copy the full SHA 6f76e88View commit details -
Merge pull request #51 from Yoast/JRF/dependabot-set-reviewer
Dependabot: add reviewer config
Configuration menu - View commit details
-
Copy full SHA for e754c95 - Browse repository at this point
Copy the full SHA e754c95View commit details -
Merge pull request #52 from Yoast/JRF/composer-update-dependencies
Composer: update dependencies
Configuration menu - View commit details
-
Copy full SHA for 481111b - Browse repository at this point
Copy the full SHA 481111bView commit details -
Merge pull request #53 from Yoast/JRF/QA/rename-parameters-for-mocked…
…-functions BrainMonkey/YoastTestCase: rename parameters for mocked functions
Configuration menu - View commit details
-
Copy full SHA for fb95b46 - Browse repository at this point
Copy the full SHA fb95b46View commit details -
GH Actions: only run tests for PRs and merges
... and not on ordinary `push` events.
Configuration menu - View commit details
-
Copy full SHA for bd82e6b - Browse repository at this point
Copy the full SHA bd82e6bView commit details -
Merge pull request #54 from Yoast/JRF/ghactions-only-run-tests-on-pr-…
…and-merge GH Actions: only run tests for PRs and merges
Configuration menu - View commit details
-
Copy full SHA for 12ad78c - Browse repository at this point
Copy the full SHA 12ad78cView commit details
Commits on Sep 11, 2023
-
GH Actions: Bump actions/checkout from 3 to 4
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for bc4b32f - Browse repository at this point
Copy the full SHA bc4b32fView commit details
Commits on Sep 23, 2023
-
Composer/PHPCS: update for YoastCS 2.3.1
Follow up on PR 52. YoastCS 2.3.1 updated the default `testVersion` to PHP `7.2-`, while this package still supports PHP 5.6.
Configuration menu - View commit details
-
Copy full SHA for 98d7f2c - Browse repository at this point
Copy the full SHA 98d7f2cView commit details -
Merge pull request #58 from Yoast/JRF/composer-update-for-yoastcs-2.3.1
Composer/PHPCS: update for YoastCS 2.3.1
Configuration menu - View commit details
-
Copy full SHA for 1762945 - Browse repository at this point
Copy the full SHA 1762945View commit details -
Well, mostly (scripts are not alphabetized, but still grouped by task). Note: this is done as a one-time only action. The normalize script will **_not_** be run in CI to enforce normalization. Style has been standardized to `--indent-style=tab --indent-size=1`. Ref: https://github.com/ergebnis/composer-normalize
Configuration menu - View commit details
-
Copy full SHA for 1215209 - Browse repository at this point
Copy the full SHA 1215209View commit details -
Composer: add script descriptions
These descriptions will be used when a list of the available scripts is requested on the command-line using the `composer list` or `composer run -l` commands. These descriptions also help document the different scripts for the maintainers of the `composer.json` file. Ref: https://getcomposer.org/doc/articles/scripts.md#custom-descriptions-
Configuration menu - View commit details
-
Copy full SHA for 31e00ef - Browse repository at this point
Copy the full SHA 31e00efView commit details -
Merge pull request #59 from Yoast/JRF/composer-tweaks
Composer: normalize the file and add script descriptions
Configuration menu - View commit details
-
Copy full SHA for aac1095 - Browse repository at this point
Copy the full SHA aac1095View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0b500d - Browse repository at this point
Copy the full SHA f0b500dView commit details -
Merge pull request #60 from Yoast/JRF/gitattributes-minor-tweaks
.gitattributes: minor clean up
Configuration menu - View commit details
-
Copy full SHA for 7d83656 - Browse repository at this point
Copy the full SHA 7d83656View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3f1bea - Browse repository at this point
Copy the full SHA a3f1beaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f0dd80 - Browse repository at this point
Copy the full SHA 9f0dd80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1aaf094 - Browse repository at this point
Copy the full SHA 1aaf094View commit details -
Tests: make dataproviders
static
As of PHPUnit 10, data providers are (again) expected to be `static` methods. This updates the test suite to respect that.
Configuration menu - View commit details
-
Copy full SHA for 153072e - Browse repository at this point
Copy the full SHA 153072eView commit details -
Merge pull request #61 from Yoast/JRF/docs-various-updates
Docs: various improvements
Configuration menu - View commit details
-
Copy full SHA for 88ec1b8 - Browse repository at this point
Copy the full SHA 88ec1b8View commit details -
Merge pull request #62 from Yoast/JRF/tests-class-should-be-final
CS/QA: all test classes should be either abstract or final
Configuration menu - View commit details
-
Copy full SHA for 55643b9 - Browse repository at this point
Copy the full SHA 55643b9View commit details -
Merge pull request #63 from Yoast/JRF/tests-static-dataproviders
Tests: make dataproviders `static`
Configuration menu - View commit details
-
Copy full SHA for 6de43fc - Browse repository at this point
Copy the full SHA 6de43fcView commit details
Commits on Sep 24, 2023
-
Backport support for the
AssertObjectProperty
polyfillPHPUnit 10.1.0 introduced two new assertions - `assertObjectHasProperty()` and `assertObjectNotHasProperty()` - to replace the `assertObjectHasAttribute() and `assertObjectNotHasAttribute()` methods, which were deprecated in PHPUnit 9.6.0 and removed in PHPUnit 10.0.0. These two new assertions have since been backported to PHPUnit 9.x in PHPUnit 9.6.11 to allow for getting rid of the deprecation notice and making preparing for PHPUnit 10 more smooth. The PHPUnit Polyfills have followed suit and the 1.1.0 release contains polyfills for the backported `assertObjectHasProperty()` and `assertObjectNotHasProperty()` methods. For the WP Test Utils package, this caused an interesting conundrum: * WP 6.4 - which enforces the use of PHPUnit Polyfills 1.1.0+ - will have the new polyfills available. * WP 5.9 - 6.3 will have the new polyfills available _if the test dependencies are updated and PHPUnit Polyfills 1.1.0+ is used_. * WP 5.2 - 5.9 versions, which include the backports, will **not** have the new polyfills available. * WP 5.2 - 5.9 versions, which **don't** include the backports, will **not** have the new polyfills available. * WP < 5.2 will **not** have the new polyfills available. Previously the WP Test Utils would have two test cases available for integration tests: * One for use with WP 5.9+ and with WP versions < 5.9 which included the backports. * One for use with WP < 5.2 and with WP versions < 5.9 which do not include the backports. To solve the conundrum, this commit: * Updates the minimum version of the PHPUnit Polyfills to 1.1.0. * Add the new polyfill to the test case which is used for WP < 5..2 and for WP versions < 5.9 which do not include the backports. * Introduces a third test case for integration tests against WP 5.2 - 5.8 versions, which _do_ include the backports, but not the new polyfill. While this third polyfill might technically not be needed, I've seen too many issues with traits colliding on older PHP versions to be willing to take that risk. * Updates the autoloader to load the correct test case. This should ensure that the new polyfill is available in all cases.
Configuration menu - View commit details
-
Copy full SHA for b0a3817 - Browse repository at this point
Copy the full SHA b0a3817View commit details
Commits on Sep 26, 2023
-
.gitattributes: minor clean up
* Sorted the list - folders first, then files, alphabetic order.
Configuration menu - View commit details
-
Copy full SHA for d80ec93 - Browse repository at this point
Copy the full SHA d80ec93View commit details -
Merge pull request #65 from Yoast/JRF/gitattributes-minor-tweaks
.gitattributes: minor clean up
Configuration menu - View commit details
-
Copy full SHA for 9484959 - Browse repository at this point
Copy the full SHA 9484959View commit details
Commits on Sep 27, 2023
-
Merge pull request #64 from Yoast/JRF/update-for-phpunit-polyfills-1.1.0
Backport support for the `AssertObjectProperty` polyfill
Configuration menu - View commit details
-
Copy full SHA for b65370b - Browse repository at this point
Copy the full SHA b65370bView commit details -
Merge pull request #57 from Yoast/dependabot/github_actions/actions/c…
…heckout-4 GH Actions: Bump actions/checkout from 3 to 4
Configuration menu - View commit details
-
Copy full SHA for 57693fe - Browse repository at this point
Copy the full SHA 57693feView commit details -
Includes adding note about Mockery 1.6.0 to the README.
Configuration menu - View commit details
-
Copy full SHA for 7e1629b - Browse repository at this point
Copy the full SHA 7e1629bView commit details -
Merge pull request #66 from Yoast/JRF/changelog-1.2.0
Changelog for release 1.2.0
Configuration menu - View commit details
-
Copy full SHA for b7e1f7b - Browse repository at this point
Copy the full SHA b7e1f7bView commit details