ACF blocks support #243
ACF blocks support #243
Conversation
Searches for custom fields in the metaboxes and post content, but not in the rest of the sidebar. This would generate duplicate results when an ACF block was selected and the preview as well as the fields in the sidebar would be passed to Yoast. Searching for ACF blocks is now performed using the WP block API, passing more correct information to the analyzer.
This is fixed with commit 1e1a2df The Travis CI is now failing because there are too many warnings, not something I should fix in this pull request IMHO. Due to the Corona virus, I am bound to a Windows PC and could not perform the tests locally. |
|
@jrfnl Seems like you are the most frequent committer here, want to take a look at this PR? |
|
Hi @TimVevida Thanks for this PR. I'm not the best person to review this, but I've checked and someone else will take a look at this PR in the near future. Regarding the warnings you see in the CI: it's true that you don't need to fix (pre-)existing issues and shouldn't in this PR, but I would like to ask you to double-check that the code affected by this PR doesn't introduce any new issues. If it does, those would need to be fixed before the PR can get merged. |
Includes changes in build of yoast-acf-analysis.js for commit 48ee009.
|
I have fixed some lint issues related to this PR and the build now passes. |
|
@TimVevida Excellent! Thank you. |
|
@jrfnl is there any timeframe when this will be merged? And will it also work in Yoast Premium plugin? |
|
@TimVevida Thank you for your PR. My apologies for not having someone looking at it sooner. I'll make sure one of our devs will look at your PR this week. There is no need to make additional changes to make it work with Premium as well (as far as I can see). |
|
@IreneStr Thats great news! |
|
CR and Acceptance ☑️ :) |
andizer
added
the
changelog: enhancement
Summary
Proof of concept that ACF block previews can be passed to Yoast SEO.
This PR can be summarized in the following changelog entry:
Relevant technical choices:
This means that in selected mode (when the preview is visible and the edit fields are visible in the sidebar), the content is passed twice to Yoast SEO. This needs a solution.
Test instructions
This PR can be tested by following these steps:
Fixes #241