Are the correct rulesets being used ?

[jrfnl]

WPCS currently has five rulesets:

• WordPress-Core - stand-alone, only rules as documented for core
• WordPress-Docs - stand-alone, only documentation rules as documented for core
• WordPress-Extra - WordPress-Core + a number of extra programming/WP best practice kind of rules
• WordPress-VIP - WordPress-Core + a number of specific rules which plugins and themes have to comply with to be allowed on to the WP VIP platform.
• WordPress - WordPress-Core + WordPress-Docs + WordPress-Extra + WordPress-VIP (all current rulesets)

Currently Yoastcs includes the WordPress-VIP ruleset and the WordPress-Docs ruleset.

As far as I know, the Yoast plugins are not deployed on the VIP platform, so do not have to comply with the VIP rules - though they do contain some hints/best practices which may be useful to check against.

So having said that, to me, it would seem more logical to check against either WordPress (everything) or against WordPress-Extra + WordPress-Docs.

Opinions ?

[atimmer]

I would prefer checking against WordPress

[jrfnl]

See PR #19.

I suggested Extra + Docs as an alternative as the Yoast-CS ruleset currently contains quite a few exclusions for VIP specific rules, so it would be worth reviewing what's left of the VIP ruleset after all the exclusions and if it's worth keeping.