Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Exception namespace #257

Closed
wants to merge 3 commits into from
Closed

Conversation

joopyoast
Copy link

Allow an extra Namespace so we can have an App/Context/Object/Exception/ structure

I also added .idea/ to the ignore files

@jrfnl
Copy link
Collaborator

jrfnl commented Aug 17, 2021

@joopyoast Sorry, but this PR does not belong here.

The recommended_max_levels and max_levels properties are in place to allow for the actual allowed level to be adjusted in project rulesets.
So not sure what project you are currently working on, but you can adjust the property in the PHPCS ruleset of the project like so:

	<rule ref="Yoast.NamingConventions.NamespaceName">
		<properties>
			<property name="recommended_max_levels" value="3"/>
			<property name="max_levels" value="4"/>
		</properties>
	</rule>

Aside from that:
Typically an ignore for an IDE specific folder, like .idea, belongs in a dev's .git/info/excludes. This project does not specify the IDE which "must" be used, so shouldn't account for it in these kind of files either.

@jrfnl jrfnl closed this Aug 17, 2021
@joopyoast
Copy link
Author

Hi Juliette,

Thanks for taking time to point me in the correct direction.
I am working on one of the projects from Yoast so I thought this would be the correct place.

@jrfnl
Copy link
Collaborator

jrfnl commented Aug 17, 2021

@joopyoast No worries, I understand this can be confusing, but this ruleset is used for all Yoast projects so a change affects them all, not just the project you are working on.
If you ever have more questions about YoastCS, know that I'm also in the Yoast Slack and there's even a dedicated #yoastcs channel. Please feel free to ping me and to ask any questions you have there and I'll try to help you.

@jrfnl jrfnl deleted the allow-exception-namespace branch September 6, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants