Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] defparam failing with default_nettype none #826

Closed
daveshah1 opened this issue Feb 24, 2019 · 3 comments
Closed

[regression] defparam failing with default_nettype none #826

daveshah1 opened this issue Feb 24, 2019 · 3 comments

Comments

@daveshah1
Copy link

daveshah1 commented Feb 24, 2019

Testcase:

`default_nettype none

module A;
parameter P = 0;
endmodule

module top;
A inst_i();
defparam inst_i.P = 1;
endmodule

Regression bisected to commit 23148ff

@daveshah1 daveshah1 changed the title [regression] [regression] defparam failing with default_nettype none Feb 24, 2019
@adumont
Copy link

adumont commented Feb 24, 2019

Hi. My project passed building (synthesizing) last week just fine (https://travis-ci.org/adumont/hrm-cpu/builds/494525894), it was using yosys at commit e45f62b.

Today, at Yosys commit c521f46, my same code is failing to synthesize with error:

hrmcpu.v:146: ERROR: Identifier \program0.PROGRAM' is implicitly declared and default_nettype is set to none.

Offending line in my code according to yosys is: https://github.com/adumont/hrm-cpu/blob/master/verilog/hrmcpu.v#L146:

defparam program0.PROGRAM = PROGRAM;

Changing to PROG #(.PROGRAM(PROGRAM)) program0 (...) seems to work as a workaround.

--

confirmed, synthesis goes well with yosys @ 974927a (previous commit), then fails with yosys @ 23148ff.

@cliffordwolf
Copy link
Collaborator

Ooops. Fixed in 1816fe0.

@adumont
Copy link

adumont commented Feb 24, 2019

Fix confirmed, working now

https://travis-ci.org/adumont/hrm-cpu/builds/497851251

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants