kernel: speedup by using more pass-by-const-ref #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise cell->setPort(ID::A, cell->getPort(ID::B)) could be invalid
boqwxp
reviewed
Mar 31, 2020
boqwxp
reviewed
Apr 9, 2020
| char ch = 0; | ||
| for (int j = 0; j < 8 && i + j < int (bits.size()); j++) | ||
| if (bits[i + j] == RTLIL::State::S1) | ||
| ch |= 1 << j; | ||
| if (ch != 0) | ||
| string_chars.push_back(ch); | ||
| string.append({ch}); |
There was a problem hiding this comment.
So, doesn't this cause an unnecessary instantiation of an initializer_list<char>? Is it not more efficient to do string.append(1, ch)? Maybe I misunderstand something, because you're even careful enough to use emplace_back() instead of push_back() above.
There was a problem hiding this comment.
An initializer_list<char> is a pair of pointers to stack; in principle, append(initializer_list<char>) should cost the same as append(int, char).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially
SigSpecandSigBit.Also speedup wire deletion by directly modifying
Module's private members.Retry of #1827...