Add parameter positional and default value information. #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, iterating over an idict returned its contents in reverse.
mwkmwkmwk
force-pushed
the
mwk/blackbox-params
branch
from
cbfaf9e
to
298e011
Compare
Fixes #1823. This will allow nextpnr to reuse the default value information already present in yosys cells_sim.v and avoid duplicating (and probably desyncing) this information.
mwkmwkmwk
force-pushed
the
mwk/blackbox-params
branch
from
298e011
to
6c92c6f
Compare
eddiehung
reviewed
Apr 22, 2020
eddiehung
added a commit
that referenced
this pull request
Apr 22, 2020
eddiehung
added a commit
that referenced
this pull request
Apr 22, 2020
Cleanup use of hard-coded default parameters in light of #1945
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.