Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proc_clean: Fix empty case removal conditions. #2641

Merged
merged 1 commit into from Mar 6, 2021
Merged

proc_clean: Fix empty case removal conditions. #2641

merged 1 commit into from Mar 6, 2021

Conversation

mwkmwkmwk
Copy link
Member

Fixes #2639.

@mwkmwkmwk mwkmwkmwk requested a review from clairexen March 6, 2021 10:07
@mwkmwkmwk mwkmwkmwk self-assigned this Mar 6, 2021
@whitequark
Copy link
Member

Oops, this is probably my fault (introduced in 18291c2?).

@mwkmwkmwk
Copy link
Member Author

Oops, this is probably my fault (introduced in 18291c2?).

Seems so; Anyway, it seems I have broken the intended use of it, but also it could be reintroduced by having a pass that detects parallel_case that is separate from proc_mux? I'd rather avoid duplicating that logic.

whitequark
whitequark approved these changes Mar 6, 2021
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections to merging this.

@mwkmwkmwk mwkmwkmwk merged commit d245e2b into master Mar 6, 2021
@mwkmwkmwk mwkmwkmwk deleted the mwk/proc-clean-fixes branch March 6, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

@clairexen clairexen Awaiting requested review from clairexen

Assignees

@mwkmwkmwk mwkmwkmwk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proc_clean overzealously deletes empty cases
2 participants
@mwkmwkmwk @whitequark