This repository has been archived by the owner on Jun 9, 2022. It is now read-only.
Add LOCK and PING commands, correct bug with error codes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
doc-hex
commented
Dec 18, 2015
doc-hex
commented
- I've added support for LOCK and PING commands.
- In the process, I found the wrong byte was being returned as a status code. Would always be one because it was looking at the length LSB, not the status code.
u1735067
added a commit
to u1735067/python-u2flib-host
that referenced
this pull request
Dec 10, 2016
Wink, lock, error read from Yubico#18 Capflags headers from https://github.com/Yubico/libu2f-host/blob/master/u2f-host/inc/u2f_hid.h#L105 byte2int fix from myself.
u1735067
added a commit
to u1735067/python-u2flib-host
that referenced
this pull request
Dec 10, 2016
Ping, lock, error read fix from Yubico#18 Capflags headers from https://github.com/Yubico/libu2f-host/blob/master/u2f-host/inc/u2f_hid.h#L105 byte2int fix from myself.
u1735067
added a commit
to u1735067/python-u2flib-host
that referenced
this pull request
Apr 18, 2017
Ping, lock, error read fix from Yubico#18 Capflags headers from https://github.com/Yubico/libu2f-host/blob/master/u2f-host/inc/u2f_hid.h#L105 byte2int fix from myself.
dainnilsson
added a commit
that referenced
this pull request
Jun 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.