This repository has been archived by the owner on Jun 9, 2022. It is now read-only.
Add ping, lock, fix error read, read capflags, fix device open error #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ping, lock, error read fix from Yubico#18 Capflags headers from https://github.com/Yubico/libu2f-host/blob/master/u2f-host/inc/u2f_hid.h#L105 byte2int fix from myself.
Remove the fox, but depends on Yubico/python-yubicommon#9
Remove my personal stuffs (debug, ..), correct the indices
|
I opted to merge PR 18 instead, since it was older and this PR seemed to borrow from it. If there are additional changes in this PR that you still require, please feel free to open a new PR. |
|
You're missing :
But thanks for taking a look |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping, lock, error read fix from #18
Capflags headers from https://github.com/Yubico/libu2f-host/blob/master/u2f-host/inc/u2f_hid.h#L105
Device open error from myself
This PR doesn't require Yubico/python-yubicommon#9 as I believe I changed all "double indices" array extraction to single indice, but it should be merged too I think.