Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ping, lock, fix error read, read capflags, fix byte2int #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ping, lock, fix error read, read capflags, fix byte2int #2

wants to merge 2 commits into from

Conversation

u1735067
Copy link
Owner

Ping, lock, error read fix from Yubico#18
Capflags headers from https://github.com/Yubico/libu2f-host/blob/master/u2f-host/inc/u2f_hid.h#L105
byte2int fix from myself.

@shuffle2
Copy link

@Alex131089 you should make a PR of your changes to yubico's repo instead of your own...

@u1735067
Copy link
Owner Author

@shuffle2 considering there's already a PR opened since Dec 2015 (Yubico#18), I'm not sure it would be merged, but let's try.
I'm not sure to remember why I did a PR to my own repo though ..

@u1735067
Copy link
Owner Author

Here you go : Yubico#23
I created another branch https://github.com/Alex131089/python-u2flib-host/tree/fixes-dep which was supposed to be dependent on Yubico/python-yubicommon#9, but as I modified the indices in this branch to clean a bit the code, it shouldn't be required anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@u1735067 @shuffle2