Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing #55

Merged
merged 1 commit into from
Mar 14, 2020
Merged

Testing #55

merged 1 commit into from
Mar 14, 2020

Conversation

JimboJoe
Copy link

@JimboJoe JimboJoe commented Feb 29, 2020 •
edited by maniackcrudelis
Loading

Problem

Solution

  • Add URL rewrite
  • Install tested manually on "root domain" ( wiki.myDomain.org ) and "sub path" (myDomain.org/dokuwiki)
  • Tested using "change URL" from YunoHost web admin too

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : Kay0u
  • Approval (LGTM) : Kay0u
  • Approval (LGTM) : Maniack C
  • CI succeeded :
    Build Status

When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@Gofannon
Url rewriting (#54)
407180e 
* Remove unused code

* Add rewrite URL functionnality

* Fix subpath handling

* Fix nginx error

nginx: [emerg] named location "@dokuwiki" can be on the server level only in /etc/nginx/conf.d/sub.example.org.d/dokuwiki.conf:20

* [enh] Enforce URL rewrite

* Increment package version
kay0u
kay0u approved these changes Feb 29, 2020
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & code review

@JimboJoe JimboJoe requested a review from a team March 7, 2020 08:40
@maniackcrudelis
Copy link

Can be merged in 3 days

@JimboJoe JimboJoe merged commit 7a70f8a into master Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kay0u kay0u kay0u approved these changes

@maniackcrudelis maniackcrudelis maniackcrudelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JimboJoe @maniackcrudelis @kay0u @Gofannon