Testing 2024.03~ynh1

[OniriCorpe]

trying to fix smarty errors

PR Status

• Code finished and ready to be reviewed/tested
• The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[yunohost-bot]

✌️

[OniriCorpe]

@aarontrom @tio-trom

i tried to fix your smarty errors, you can test it with (only if all the tests in the previous message are green):
yunohost app upgrade friendica -u https://github.com/YunoHost-Apps/friendica_ynh/tree/testing

and tell me if it's fixed or not

[tio-trom]

The test failed so we will wait until that's fixed to try it. Thanks a lot for your wonderful work!

[yunohost-bot]

😜

[OniriCorpe]

Thanks a lot for your wonderful work!

I don't even use Friendica lmao :")

[tio-trom]

Thanks a lot for your wonderful work!

I don't even use Friendica lmao :")

Well and that's even more respectable since you are helping people like us use friendica. Thanks!

[tio-trom]

I see that the test failed

==> /var/log/friendica <==
tail: error reading '/var/log/friendica': Is a directory

==> /var/log/friendica/daemon.log <==
    'system' => [
        'pidfile' => '/path/to/daemon.pid',
    ],Please set system.pidfile in config/local.config.php. For example:

    'system' => [
        'pidfile' => '/path/to/daemon.pid',
    ],Please set system.pidfile in config/local.config.php. For example:

    'system' => [
        'pidfile' => '/path/to/daemon.pid',
    ],Please set system.pidfile in config/local.config.php. For example:

    'system' => [
        'pidfile' => '/path/to/daemon.pid',
    ],Error: The HTTP code shows an error.

[OniriCorpe]

yes, i need to debug that, but i don't have time for that in the current days, as i'm also working on yunohost itself and that I have extremely limited energy :/

[tio-trom]

yes, i need to debug that, but i don't have time for that in the current days, as i'm also working on yunohost itself and that I have extremely limited energy :/

I understand. Thank you. Whenever the package is ready for testing I'll be happy to test.

[tio-trom]

I think the errors I and Aaron had were because the friendica config files were manually modified by us to enable the daemon long before this PR. So perhaps close/merge this one so we can do a proper updating to the #134 one but reverting the changes manually and then do the update.

[kay0u]

!testme

[yunohost-bot]

May the CI gods be with you!

[yunohost-bot]

🐛

[rodneyrod]

Just outta curiosity this upgrade fail has nothing to do with permissions at '/var/www/friendica/view/smarty3/compiled/' not being set to the Friendica user?

[rodneyrod]

Did some testing, this part (41-45) probably needs to be above the chmod and chown steps in lines 38 and 39, otherwise the compiled folder gets owned by root and Friendica nor www-data can't write to that directory.

[tio-trom]

How is this pullrequest comparing or conflicting with the already update to 2024.03 #134 ? I would like to update my friendica but unsure if I should go for #134 or wait for this issue to be fixed?

[ericgaspar]

!testme

[yunohost-bot]

May the CI gods be with you!

[yunohost-bot]

📚 🐛

[ericgaspar]

Has this been tested?

[tio-trom]

I would like to test it but I got confused by the several merge requests hat happened for this 2023.03 release. I would like to know what version I could test so I can test please

[ericgaspar]

sudo yunohost app install https://github.com/YunoHost-Apps/friendica_ynh/tree/testing --debug
or
sudo yunohost app upgrade friendica -u https://github.com/YunoHost-Apps/friendica_ynh/tree/testing --debug

[tio-trom]

I see so you merged them into testing. Ok I will test it today. I need a bit of time since our instance has around one thousand users and I do not want to cause any major issues. I will report when I am done. Thanks!

[ericgaspar]

maybe someone with less users could test...

[tio-trom]

Updated and all seems to work perfectly fine. Full log here https://paste.trom.tf/hotabucuwi.sql