New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Permissions for enigma plugin closes #21 #22
Conversation
scripts/install
Outdated
@@ -179,7 +179,7 @@ ynh_store_file_checksum "${final_path}/config/config.inc.php" | |||
#================================================= | |||
|
|||
# Set permissions to app files | |||
chown -R root: "$final_path" | |||
chown -R $app: "$final_path" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should limit your owner change to the strict minimum, so to the enigma folder or plugins folder.
Furthermore, you should also handle the upgrade script as well 😉
Issue 21 says "directory isn't writeable: /var/www/roundcube/plugins/enigma/home" |
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and upgrade from previous version OK 👍
Thanks @Rafi594, will be merged in 3 days. |
Problem
Solution
PR Status
Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.
Validation
Minor decision
When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.