Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing #26

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Testing #26

merged 1 commit into from
Jan 12, 2018

Conversation

JimboJoe
Copy link
Contributor

@JimboJoe JimboJoe commented Dec 17, 2017 •
edited by maniackcrudelis
Loading

Problem

Solution

PR Status

Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.

Validation

Minor decision

@JimboJoe
[fix] Permissions for enigma plugin closes #21 (#22)
d6da975 
* [fix] Permissions for enigma plugin
* Update install
* [fix] Permissions
* Update install
* Update upgrade
@maniackcrudelis maniackcrudelis requested a review from a team January 8, 2018 20:04
@maniackcrudelis
Copy link
Contributor

Ready to be reviewed.

@JimboJoe
Copy link
Contributor Author

JimboJoe commented Jan 9, 2018

It's exactly the same content as #26 (already reviewed), couldn't we merge all the way?

@JimboJoe JimboJoe closed this Jan 9, 2018
@JimboJoe JimboJoe reopened this Jan 9, 2018
@maniackcrudelis
Copy link
Contributor

OK.
Will be merge in 3 days.

@maniackcrudelis maniackcrudelis merged commit a780644 into master Jan 12, 2018
maniackcrudelis added a commit to YunoHost/apps that referenced this pull request Jan 12, 2018
@maniackcrudelis
Update jirafeau, roundcube and shellinabox
8990a56 
YunoHost-Apps/jirafeau_ynh#38
YunoHost-Apps/roundcube_ynh#26
YunoHost-Apps/shellinabox_ynh#5
@maniackcrudelis maniackcrudelis mentioned this pull request Jan 12, 2018
Merged
JimboJoe pushed a commit to YunoHost/apps that referenced this pull request Jan 12, 2018
@maniackcrudelis @JimboJoe
Update jirafeau, roundcube and shellinabox (#403)
3e95cce 
YunoHost-Apps/jirafeau_ynh#38
YunoHost-Apps/roundcube_ynh#26
YunoHost-Apps/shellinabox_ynh#5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maniackcrudelis maniackcrudelis maniackcrudelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimboJoe @maniackcrudelis