Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to synapse v1.3.1 #145

Merged
merged 3 commits into from Sep 10, 2019
Merged

Upgrade to synapse v1.3.1 #145

merged 3 commits into from Sep 10, 2019

Conversation

Josue-T
Copy link

@Josue-T Josue-T commented Aug 19, 2019 •
edited by kay0u

Problem

  • The package is not up to date

Solution

  • Update the package

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : JimboJoe
  • Approval (LGTM) : JimboJoe
  • Approval (LGTM) : Kay0u
  • CI succeeded :

Build Status

When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@Josue-T Josue-T requested a review from a team August 19, 2019 22:14
JimboJoe
JimboJoe previously approved these changes Aug 20, 2019
View reviewed changes
Copy link

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and code review OK 👍

@JimboJoe JimboJoe requested a review from a team August 20, 2019 05:25
@Josue-T Josue-T mentioned this pull request Aug 22, 2019
Merged
8 tasks
@Josue-T Josue-T requested review from JimboJoe and a team and removed request for a team September 4, 2019 12:04
@Josue-T
Copy link
Author

Josue-T commented Sep 7, 2019

Can somebody review this PR...

@kay0u
Copy link
Member

kay0u commented Sep 7, 2019

Can be merged in 3 days

@Josue-T Josue-T merged commit eca5232 into testing Sep 10, 2019
@Josue-T Josue-T deleted the v1.3 branch September 10, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimboJoe JimboJoe JimboJoe approved these changes

@kay0u kay0u kay0u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Josue-T @kay0u @JimboJoe