Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller #268

Merged
merged 28 commits into from
Aug 14, 2021
Merged

Smaller #268

merged 28 commits into from
Aug 14, 2021

Conversation

yalh76
Copy link
Member

@yalh76 yalh76 commented May 27, 2021

Problem

  • Backups are hudge

Solution

  • Remove .rustup (396Mo) .cargo (198Mo) folder after building matrix-synapse (159Mo)

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@yalh76
Copy link
Member Author

yalh76 commented May 27, 2021

!testme

@yunohost-bot
Copy link

🎠
Test Badge

@yalh76 yalh76 requested a review from Josue-T May 27, 2021 12:15
@yalh76
Copy link
Member Author

yalh76 commented Aug 13, 2021

ping @Josue-T

@lapineige
Copy link
Member

Upgrade went well :)

@Josue-T
Copy link

Josue-T commented Aug 24, 2021

Well, I think it's really not a good idea as with this we always download all rust package at each upgrade...

@Josue-T Josue-T mentioned this pull request Aug 24, 2021
2 tasks
@yalh76
Copy link
Member Author

yalh76 commented Aug 24, 2021

Well, I think it's really not a good idea as with this we always download all rust package at each upgrade...

I agree with that point, it was one of my thinking when i've done that PR

The point is:

  • current x86_64: synapse installation : /opt/yunohost/matrix-synapse (759Mo) including .rustup (379Mo) .cargo (223Mo) so cached files represent 660Mo => 80% of the total installation.

What is it better:

  • Not having to download 660Mo of files during upgrades: few seconds won
  • In the 660Mo, I don't know which part of the stable toolchain is redownload during upgrade,...
    or
  • Having quicker and smaller backup during upgrades
  • Having quicker and smaller backup for users doing weekly or daily backup

That's why I though that few seconds added during upgrade worth the space and time saved during backup

@lapineige
Copy link
Member

* Not having to download 660Mo of files during upgrades: few seconds won

It depends : or some home-hosted servers, this might take a while (1MB/s on a regular ADSL takes a whole minute, fully loading the connection).
But that's not too bad anyway. And you do that only for upgrades.

Having quicker and smaller backup during upgrades
Having quicker and smaller backup for users doing weekly or daily backup

That's why I though that few seconds added during upgrade worth the space and time saved during backup

Well, on slow internet connections but quite powerful servers, I'm not even sure this is time lost (saving 660Mo to copy then compress…). It's energy and heat saved too (much less CPU load).

@Josue-T
Copy link

Josue-T commented Aug 28, 2021

Maybe a better solution is to store the rust data somewhere else (by example in /opt/yunohost/rust-build-synapse) and make just a symbolic link to this directory for the rust data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants