Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade synapse to 0.26.1 #38

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Upgrade synapse to 0.26.1 #38

merged 1 commit into from
Mar 21, 2018

Conversation

Josue-T
Copy link

@Josue-T Josue-T commented Mar 16, 2018

Problem

Solution

Update the app

PR Status

Work finished. Tested on ARM and x86.
Could be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version : JimboJoe
  • Code review : JimboJoe
  • Approval (LGTM) : JimboJoe
  • Approval (LGTM) : Maniack C
  • CI succeeded : Build Status
    When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

@Josue-T Josue-T requested a review from a team March 16, 2018 18:57
Copy link

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and upgrade from previous version OK 👍

@maniackcrudelis
Copy link

Can be merged in 3 days.

@Josue-T Josue-T merged commit 9a9c697 into testing Mar 21, 2018
@maniackcrudelis maniackcrudelis deleted the Update_to_0.26.1 branch March 21, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants