Testing #101

lapineige · 2021-04-09T08:11:58Z

Problem

New official version available

Solution

Update to 2.4.2

PR Status

[autopatch] Autopatch to migrate to new permission system

[autopatch] Missing ynh_abort_if_errors in change_url scripts

* Tighten permissions * Check for existence of cache file before chmoding it

Quash the last package_check warning

CI gives us this warning: > ! Using official helper ynh_permission_update implies requiring at least version 3.7.0, but manifest only requires 3.5

* Upgrade to upstream version 2.4.2

lapineige · 2021-04-09T08:12:55Z

!testme

yunohost-bot · 2021-04-09T08:13:00Z

🌻

lapineige · 2021-04-09T08:56:25Z

Upgrade from master fails in my case:

ERROR     [console] Error thrown while running command "--no-interaction --env prod doctrine:migrations:migrate". Message: "An exception occurred while executing 'ALTER TABLE `oauth2_access_tokens` DROP FOREIGN KEY FK_SomeRandomNumber':
WARNING: SQLSTATE[42000]: Syntax error or access violation: 1091 Can't DROP FOREIGN KEY `FK_SomeRandomNumber`; check that it exists" ["exception" => Doctrine\DBAL\Exception\DriverException { …},"command" => "--no-interaction --env prod doctrine:migrations:migrate","message" => """  An exception occurred while executing 'ALTER TABLE `oauth2_access_tokens` DROP FOREIGN KEY FK_SomeRandomNumber':\n  \n  SQLSTATE[42000]: Syntax error or access violation: 1091 Can't DROP FOREIGN KEY `FK_SomeRandomNumber`; check that it exists  """]

lapineige · 2021-04-09T16:16:37Z

@YunoHost-Apps/apps-group you probably know that better than me : I believe the CI test upgrade from latest version, but which precise version ? Latest master ?

CI says Upgrade (f75d58cb): OK but f75d58c is not the latest commit in master.

yalh76 · 2021-04-09T20:09:52Z

@YunoHost-Apps/apps-group you probably know that better than me : I believe the CI test upgrade from latest version, but which precise version ? Latest master ?

CI says Upgrade (f75d58cb): OK but f75d58c is not the latest commit in master.

At least from the last master :)
2.3.8~ynh3 => fc84732

lapineige · 2021-04-09T21:00:45Z

So to what commit that "f75d58cb" is referring to ?

Does that works also with a very recently merged commit ?

yalh76 · 2021-04-09T21:04:48Z

in fact, it's fc847322efbede1654d4c201ffd5855e3cb53774 current master

lapineige · 2021-04-10T07:39:01Z

But if I understand well the summary, it's using this very old commit from 2017 f75d58c, isn't it ?

Note: I'm trying to figure out that to know if I discovered a particular issue in my wallabag instance, or a more general bug during the upgrade.

alexAubin

(Super quick review, LGTM but not super familiar with the app)

lapineige · 2021-04-20T07:02:13Z

I tested again, I have this strange bug again…

Can someone else try to upgrade and see if it works correctly ?

nicofrand · 2021-04-21T11:01:41Z

@lapineige I just tried a fresh install (I did not add any article though) and then an upgrade from testing and it looked OK to me: https://paste.yunohost.org/raw/loposuqubo.

lapineige · 2021-04-21T11:46:15Z

Then that's an issue with my instance… great 😅

nicofrand · 2021-04-21T12:40:12Z

I did not test on my production instance though, I don't want to lose anything. Does the upgrade fail gracefully on your instance (ie. you don't lose anything and 2.3.8 is still working after the upgrade failure)?

lapineige · 2021-04-21T14:45:31Z

Yes it does.
(I did backup my articles just in case)

If you can try it, maybe you can import a few/all articles from your production instance, and try to upgrade ?

I wonder how I could solve my bug… I don't understand it 😅

nicofrand · 2021-04-22T06:46:57Z

OK, I got some errors too on production: https://paste.yunohost.org/raw/vugedeceko

nicofrand · 2021-04-22T07:07:21Z

Also see wallabag/wallabag#4826

lapineige · 2021-04-22T07:18:01Z

We are not lucky, that we waited for 2.4.1 to include those fixes, and that we still have the issue 😅

! Using official helper ynh_legacy_permissions_delete_all implies requiring at least version 4.1, but manifest only requires 3.7.0 ! Using official helper ynh_legacy_permissions_exists implies requiring at least version 4.1, but manifest only requires 3.7.0

yalh76

Quick review, LGTM

yalh76 · 2021-04-24T10:58:40Z

!testme

yunohost-bot · 2021-04-24T10:58:42Z

🚀

lapineige · 2021-04-24T20:09:40Z

I think we need to wait for a feedback from wallabag/wallabag#5233

The issue I encountered doesn't seem to be specific to my instance, and the CI can't test that.
Until we find a fix, I'm against merging this to master, the risk of breaking people instances is too high in my opinion.

yalh76 · 2021-04-25T10:32:10Z

OK then, I let you move forward on this :)

Co-authored-by: Yunohost-Bot <>

This reverts commit d42b210.

Co-authored-by: Yunohost-Bot <>

lapineige · 2021-06-06T20:16:37Z

Wait, did we merged this while you issue mentioned above is not fixed ? I hope that won't break anything…

alexAubin · 2021-06-06T20:20:25Z

Ugh indeed, didn't read that carefully ... At least the backup process before upgrade should still work

If you or anybody can confirm the issue, we can revert the merge I guess..

lapineige · 2021-06-06T20:26:42Z

Both @nicofrand and I did encounter that issue.
I would prefer to wait until we have some feedback on the related issue in wallabag official repository before merging to master.

The backup is here indeed, but I prefer that people whiling to test come here to test that PR/testing branch than the risk to break a lot of instances and rely on the backup system & stuff like that. 2 people encountering the error is a small sample, I'm not sure it's a frequent issue, but this app is used by many people and I'd prefer to stay a bit conservative, just in case. It's not that difficult to install this branch if someone really need the new version.

@alexAubin do you know if a revert can have any (bad) impact on current servers that did upgrade already ?

alexAubin · 2021-06-06T20:44:28Z

Alrighty, I guess reverting should be okay since it was only merged hours ago ... I created a revert-of-the-revert here that we can merge once the upstream issue is resolved : #106

lapineige · 2021-06-06T20:45:58Z

At first I was a bit lost, but ok now I understand, #106 is like merging this PR again when we think it is ready.

ericgaspar and others added 11 commits October 22, 2020 15:16

Add badges

d1b511d

Add badges

0e921ba

[autopatch] Missing ynh_abort_if_errors in change_url scripts

e7abd27

[autopatch] Autopatch to migrate to new permission system

b21f940

Remove stale comment

e563ac3

Merge pull request #93 from yunohost-bot/new-permission-system

c6c8158

[autopatch] Autopatch to migrate to new permission system

Merge pull request #92 from yunohost-bot/missing-seteu-in-change_url

0303873

[autopatch] Missing ynh_abort_if_errors in change_url scripts

Tighten permissions (#99)

0be55ed

* Tighten permissions * Check for existence of cache file before chmoding it

Install PHP packages of YNH_PHP_VERSION (#100)

d87c241

Quash the last package_check warning

Update package version + yunohost requirements

5152058

CI gives us this warning: > ! Using official helper ynh_permission_update implies requiring at least version 3.7.0, but manifest only requires 3.5

Upgrade to upstream version 2.4.2 (closes #88) (#90)

eefec14

* Upgrade to upstream version 2.4.2

lapineige added the enhancement label Apr 9, 2021

Merge branch 'master' into testing

d04e27a

lapineige added the help wanted label Apr 9, 2021

alexAubin reviewed Apr 19, 2021

View reviewed changes

nicofrand mentioned this pull request Apr 22, 2021

Upgrade v2.3.8 --> v2.4.2 database migration failed on table 'wallabag_user' wallabag/wallabag#5197

Closed

version 4.1.0

afdd82c

! Using official helper ynh_legacy_permissions_delete_all implies requiring at least version 4.1, but manifest only requires 3.7.0 ! Using official helper ynh_legacy_permissions_exists implies requiring at least version 4.1, but manifest only requires 3.7.0

yalh76 approved these changes Apr 24, 2021

View reviewed changes

yalh76 mentioned this pull request Apr 24, 2021

Update app's level YunoHost/apps#1137

Merged

4 tasks

lapineige added bug pending and removed help wanted labels Apr 24, 2021

yalh76 marked this pull request as draft April 25, 2021 10:31

yunohost-bot and others added 3 commits May 11, 2021 08:30

[autopatch] Update issue and PR templates (#102)

d42b210

Co-authored-by: Yunohost-Bot <>

Revert "[autopatch] Update issue and PR templates (#102)" (#103)

d40d78b

This reverts commit d42b210.

[autopatch] Update issue and PR templates (#104)

f88f439

Co-authored-by: Yunohost-Bot <>

yalh76 approved these changes May 13, 2021

View reviewed changes

alexAubin approved these changes Jun 6, 2021

View reviewed changes

yalh76 marked this pull request as ready for review June 6, 2021 17:01

yalh76 merged commit 0dcbec9 into master Jun 6, 2021

This was referenced Jun 6, 2021

Revert "Testing" #105

Merged

[Pending, need testers] Update to 2.4.2 (Revert "Revert "Testing"") #106

Closed

lapineige mentioned this pull request Sep 13, 2021

official 2.3.8 migration to 2.4.2 in YNH #113

Closed

lapineige mentioned this pull request Feb 15, 2022

2.4.3 #125

Merged

4 tasks

lapineige mentioned this pull request Mar 14, 2022

Upgrade old DB scheme (migration to 2.4.x for pre-2018 installs) #129

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Testing #101

Testing #101

lapineige commented Apr 9, 2021 •

edited

Loading

lapineige commented Apr 9, 2021

yunohost-bot commented Apr 9, 2021

lapineige commented Apr 9, 2021 •

edited

Loading

lapineige commented Apr 9, 2021

yalh76 commented Apr 9, 2021

lapineige commented Apr 9, 2021

yalh76 commented Apr 9, 2021

lapineige commented Apr 10, 2021 •

edited

Loading

alexAubin left a comment

lapineige commented Apr 20, 2021

nicofrand commented Apr 21, 2021

lapineige commented Apr 21, 2021

nicofrand commented Apr 21, 2021

lapineige commented Apr 21, 2021 •

edited

Loading

nicofrand commented Apr 22, 2021

nicofrand commented Apr 22, 2021

lapineige commented Apr 22, 2021

yalh76 left a comment

yalh76 commented Apr 24, 2021

yunohost-bot commented Apr 24, 2021

lapineige commented Apr 24, 2021

yalh76 commented Apr 25, 2021

lapineige commented Jun 6, 2021

alexAubin commented Jun 6, 2021

lapineige commented Jun 6, 2021 •

edited

Loading

alexAubin commented Jun 6, 2021

lapineige commented Jun 6, 2021

Testing #101

Testing #101

Conversation

lapineige commented Apr 9, 2021 • edited Loading

Problem

Solution

PR Status

lapineige commented Apr 9, 2021

yunohost-bot commented Apr 9, 2021

lapineige commented Apr 9, 2021 • edited Loading

lapineige commented Apr 9, 2021

yalh76 commented Apr 9, 2021

lapineige commented Apr 9, 2021

yalh76 commented Apr 9, 2021

lapineige commented Apr 10, 2021 • edited Loading

alexAubin left a comment

Choose a reason for hiding this comment

lapineige commented Apr 20, 2021

nicofrand commented Apr 21, 2021

lapineige commented Apr 21, 2021

nicofrand commented Apr 21, 2021

lapineige commented Apr 21, 2021 • edited Loading

nicofrand commented Apr 22, 2021

nicofrand commented Apr 22, 2021

lapineige commented Apr 22, 2021

yalh76 left a comment

Choose a reason for hiding this comment

yalh76 commented Apr 24, 2021

yunohost-bot commented Apr 24, 2021

lapineige commented Apr 24, 2021

yalh76 commented Apr 25, 2021

lapineige commented Jun 6, 2021

alexAubin commented Jun 6, 2021

lapineige commented Jun 6, 2021 • edited Loading

alexAubin commented Jun 6, 2021

lapineige commented Jun 6, 2021

lapineige commented Apr 9, 2021 •

edited

Loading

lapineige commented Apr 9, 2021 •

edited

Loading

lapineige commented Apr 10, 2021 •

edited

Loading

lapineige commented Apr 21, 2021 •

edited

Loading

lapineige commented Jun 6, 2021 •

edited

Loading