Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DownloadPageAPI to the autoupdater to download from HTML web pages #2041

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add DownloadPageAPI to the autoupdater to download from HTML web pages #2041

wants to merge 5 commits into from

Conversation

Salamandar
Copy link
Contributor

Tested with Jitsi and this configuration:

autoupdate.strategy = "latest_webpage_link"
autoupdate.upstream = "https://download.jitsi.org/stable/"
autoupdate.version_regex = "^jitsi-meet-web_([\\d\\.\\-]*)_all.deb$"

@orhtej2
Copy link
Contributor

orhtej2 commented Feb 20, 2024

I'm not saying it's a bad idea, I'm saying it's brittle as is web scraping in general 🤔

@Salamandar
Copy link
Contributor Author

The version_regex is matching against the link "content" (name ?).

@Salamandar
Copy link
Contributor Author

I'm not saying it's a bad idea, I'm saying it's brittle as is web scraping in general 🤔

Ah yes, agreed! But it's kind of an internal tool, if it breaks, no user will complain, so i'd say it's okay to have a not-really-hardened tool there.

OniriCorpe
OniriCorpe approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@OniriCorpe OniriCorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this handy shit

@OniriCorpe OniriCorpe mentioned this pull request Mar 15, 2024
Open
@fflorent
Copy link
Contributor

FWIW, I would probably need that for elasticsearch8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Psycojoker Psycojoker Psycojoker requested changes

@OniriCorpe OniriCorpe OniriCorpe approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
tools
Projects
None yet
Milestone
No milestone
6 participants
@Salamandar @orhtej2 @fflorent @Psycojoker @OniriCorpe @tituspijean