Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod] use ask key for display_text instead and support i18n #697

Merged
merged 1 commit into from Apr 2, 2019

Conversation

Projects
None yet
3 participants
@Psycojoker
Copy link
Member

commented Mar 31, 2019

The problem

While working on the admin integration I realized that uniformizing the behavior with other key and using "ask" instead of "text" was way simpler for the whole code (despite not making that much sens for "display_text" field) and annex tool (i18n integration for example).

I also added i18n support.

PR Status

Ready to merge.

How to test

Use this app and try to install it https://github.com/Psycojoker/display_text_ynh

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin added this to the 3.5.x milestone Apr 1, 2019

@alexAubin

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

smol change, yolomergin'

@alexAubin alexAubin merged commit 1c7aadd into stretch-unstable Apr 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the manifest_texte_argument branch Apr 2, 2019

@Psycojoker

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2019

@YunoHost/apps just to inform you about the final format ^

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

Final format of that #669, I guess ?

So it would be that: ?

{
    "name": "some_text",
    "type": "display_text",
    "ask": "This is some text that is going to be displayed.\n\nAnother line."
},

With ask instead of text

@Psycojoker

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.