This repository has been archived by the owner on Jul 3, 2020. It is now read-only.
Small optimization in checking assertions #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| namespace ZfcRbac\Service; | |||
|
|
|||
| use Callable; | |||
There was a problem hiding this comment.
Remove it. use only "callable" in docblock. callable is not a class, it's a type.
There was a problem hiding this comment.
@bakura10 😅 I thought it was an interface such as Traversable. Fixed.
| if ($this->rbac->isGranted($role, $permission)) { | ||
| $isGranted = true; | ||
| break; | ||
| return ($assertion) ? $this->assert($assertion) : true; |
There was a problem hiding this comment.
The ternary operator here is ok? Looks readable?
bakura10
added a commit
that referenced
this pull request
Dec 23, 2013
Small optimization in checking assertions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just removes the
$isGranted