-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for z/OS codepage encodings #21
Comments
If a user wants attributes to apply globally, they can define them in their |
makes sense to me. this would be good to discuss at the next guild call |
Created PR: #22 |
As most users will be coming from Rocket Git I would recommend keeping support for |
I would like to have an option (preferably an environment variable) to totally ignoring file tags and make git works exactly like it is on non-filetag platforms. |
PR for platform-working-tree-encoding in #23 (On z/OS, platform gets substituted with zos). This should make it compatible with Rocket's git. |
@ccw-1 @IgorTodorovskiIBM what is more git-like - to use an env var or a config setting? For config, it could then be local or global? |
We could probably add a new git config setting like |
Yes, core.ignoretags is a good idea. then it can be set on a per repository basis. |
So I understand, if someone had provided a .gitattributes file with encodings, those encodings would still be processed correct? The core.ignoretags would just be for 'unspecified' files not covered with 'working-tree-encoding'? core.defaulttag and have the 'default' be ISO8859-1 but one could specify:
|
This is done. @IgorTodorovskiIBM if not, please re-open |
According to Rocket’s Git 2.26.2 release notes
It seems that the only supported attribute in .gitattributes is
zos-working-tree-encoding
.It also turns out that the
git-encoding
attribute is redundant and no longer needed:Additionally, the attribute we're using,
working-tree-encoding
, conflicts with the attribute of the same name that Git upstream added. it is no longer recommended due to the following reason:So, we could continue to go along with Rocket's approach (use zos-working-tree-encoding) or come up with our own approach that is a bit more generalized.
My take:
Given that "working-tree-encoding" is already supported by the latest versions of Git, and the only issue with it being that we want the encodings to apply to our platform, z/OS, I am thinking that we could add an OS or platform flag to filter where the working-tree-encoding attribute should apply. This flag would be similar to the eol flag documented here: https://git-scm.com/docs/gitattributes
For example:
And not specifying the os filter would mean that
would apply to all platforms.
The text was updated successfully, but these errors were encountered: