Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: optionally allow primes to persist through normalization on double turns. For example: U2' => U2' #1

Open
bnat1 opened this issue Nov 21, 2018 · 2 comments

Comments

@bnat1
Copy link

bnat1 commented Nov 21, 2018

I understand that in "standard" notation, double moves aren't usually inverted. But for execution, it can be helpful to distinguish double turns from prime double turns. It would be great if there was an option, something like { allowDoublePrime: true/false }, with default false, that allows for normalizing with execution.

I'm going to fork this project and implement this change. I'll comment here / make a pr when the change is made in case you want to include this functionality in the project.

@Zahajki
Copy link
Owner

Zahajki commented Nov 21, 2018

I'm not sure about what you really want, anyway, notations like U2' are already supported (without any options). There is no restriction about the order of primes and numbers.

normalize("U2'");
// => "U2"
normalize("U'2");
// => "U2"

For more detail, see syntax definition and test case.

@bnat1
Copy link
Author

bnat1 commented Nov 21, 2018

Right, what I meant, was it would be nice to optionally allow the prime to persist after normalization, like this:
normalize("U2'", { doublePrimeMoves: true }); // => "U2'"
The reason being, imagine that I want to preserve how an algorithm is executed. Currently, the detail of the turn being prime would be lost through normalization.

@bnat1 bnat1 changed the title Feature request: optionally allow double prime moves. For example: U2' Feature request: optionally allow primes to persist through normalization on double turns. For example: U2' => U2' Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants