getaddresstxids JSON-RPC method

[mpguerra]

Motivation

lightwalletd uses the getaddresstxids JSON-RPC method.

This method returns the transaction IDs for both spent and unspent transparent outputs: https://github.com/zcash/zcash/blob/c76b756a688bfa0a4396a45355814cdc9f9a47e3/src/main.cpp#L3170

Requirements

Returned txids are in the order they appear in blocks.
(This ensures that they are topologically sorted.)

Required Fields

The method is documented here: https://zcash.github.io/rpc/getaddresstxids.html

But only the multi-argument format is used by lightwalletd: https://github.com/zcash/lightwalletd/blob/631bb16404e3d8b045e74a7c5489db626790b2f6/common/common.go#L97-L102

Argument list:

{
  "addresses":
    [
      "taddr"  (string) The base58check encoded address
      ,...
    ]
  "start" (number, optional) The start block height
  "end" (number, optional) The end block height
}

Field list:

[
  "transactionid"  (string) The transaction id
  ,...
]

Tasks

Implementation:

• Implement the new ReadRequest for ReadState
  Use the non-finalized and finalized indexes if they are ready (or an empty list if these tickets are still open):
  • Add tx_loc_by_transparent_addr_loc index to the finalized state #3951
  • feat(state): add transparent address indexes to the non-finalized state #4022
• Implement the RPC method

Testing:

• Add RPC unit tests
• Test that the RPC method works with lightwalletd

[ftm1000]

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @gustavovalverde @jvff @oxarbitrage @teor2345 @upbqdn

[teor2345]

The state parts of this ticket aren't merged yet (#4038, #4022), but you could add a state request/response that returns an empty list of transactions.