Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use discussed RPC documentation format in already merged (or in progress) methods #3764

Closed
oxarbitrage opened this issue Mar 7, 2022 · 0 comments · Fixed by #3868
Closed

Use discussed RPC documentation format in already merged (or in progress) methods #3764

oxarbitrage opened this issue Mar 7, 2022 · 0 comments · Fixed by #3868
Labels
A-docs Area: Documentation A-rpc Area: Remote Procedure Call interfaces C-cleanup Category: This is a cleanup lightwalletd any work associated with lightwalletd

Comments

@oxarbitrage
Copy link
Contributor

We are discussing what will be standard format for RPC method documentation in #3638

However we already merged (or are in progress of) some methods that will need to be changed to this new format.

This include at the moment of writing:

  • getinfo
  • sendrawtransaction
  • getblock
  • getbestblockhash
@oxarbitrage oxarbitrage changed the title Use RPC documentation format in already merged methods Use discussed RPC documentation format in already merged methods Mar 7, 2022
This was referenced Mar 7, 2022
Merged
Merged
@oxarbitrage oxarbitrage added the A-docs Area: Documentation label Mar 7, 2022
@oxarbitrage oxarbitrage changed the title Use discussed RPC documentation format in already merged methods Use discussed RPC documentation format in already merged (or in progress) methods Mar 7, 2022
@teor2345 teor2345 added A-rpc Area: Remote Procedure Call interfaces C-cleanup Category: This is a cleanup P-Low ❄️ labels Mar 8, 2022
@oxarbitrage oxarbitrage mentioned this issue Mar 14, 2022
Merged
@mergify mergify bot closed this as completed in #3868 Mar 15, 2022
@ftm1000 ftm1000 added the lightwalletd any work associated with lightwalletd label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: Documentation A-rpc Area: Remote Procedure Call interfaces C-cleanup Category: This is a cleanup lightwalletd any work associated with lightwalletd
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(rpc): refactor method docs according to discussion ZcashFoundation/zebra
3 participants
@teor2345 @oxarbitrage @ftm1000