Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add database snapshot tests for the scanner database #8069

Closed
3 tasks done
Tracked by #7728
teor2345 opened this issue Dec 6, 2023 · 5 comments · Fixed by #8075, #8083 or #8106
Closed
3 tasks done
Tracked by #7728

test: Add database snapshot tests for the scanner database #8069

teor2345 opened this issue Dec 6, 2023 · 5 comments · Fixed by #8075, #8083 or #8106
Assignees
@teor2345
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-usability Zebra is hard to understand or use S-needs-triage Status: A bug report needs triage

Comments

@teor2345
Copy link
Contributor

teor2345 commented Dec 6, 2023 •
edited
Loading

Motivation

Add these snapshot tests to the scanner:

These tests already exist for the state, we just need to copy and paste and change the config to the scanner.

Testing

These are new tests.

Related Work

Split off #8037
@teor2345 teor2345 added S-needs-triage Status: A bug report needs triage P-Medium ⚡ I-usability Zebra is hard to understand or use C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Dec 6, 2023
This was referenced Dec 6, 2023
Closed
Closed
@teor2345 teor2345 self-assigned this Dec 7, 2023
@teor2345 teor2345 changed the title test: Add database conflict and ephemeral tests for the scanner database test: Add standard database tests for the scanner database Dec 7, 2023
@teor2345 teor2345 removed their assignment Dec 7, 2023
@teor2345 teor2345 mentioned this issue Dec 7, 2023
Merged
7 tasks
@teor2345
Copy link
Contributor Author

teor2345 commented Dec 7, 2023

I'm doing the snapshot tests in this ticket.

@teor2345 teor2345 mentioned this issue Dec 11, 2023
Merged
7 tasks
This was linked to pull requests Dec 11, 2023
test(scan): Add raw database format snapshots to the scanner #8075
Merged
test(scan): Add typed database format snapshots to the scanner #8083
Merged
@mergify mergify bot closed this as completed in #8075 Dec 12, 2023
@teor2345
Copy link
Contributor Author

Only part of this is done.

@teor2345 teor2345 reopened this Dec 12, 2023
@mergify mergify bot closed this as completed in #8083 Dec 12, 2023
@mpguerra
Copy link
Contributor

@teor2345 can I get an estimate here also?

@teor2345 teor2345 changed the title test: Add standard database tests for the scanner database test: Add database snapshot tests for the scanner database Dec 13, 2023
@teor2345
Copy link
Contributor Author

This issue still isn't complete, I'm not sure why it keeps closing

@teor2345 teor2345 reopened this Dec 13, 2023
@teor2345 teor2345 mentioned this issue Dec 13, 2023
Closed
3 tasks
@teor2345
Copy link
Contributor Author

I split out #8102 because the snapshot tests are required and almost done, but the other database tests are a low priority.

@teor2345 teor2345 mentioned this issue Dec 13, 2023
Merged
7 tasks
@mergify mergify bot closed this as completed in #8106 Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-usability Zebra is hard to understand or use S-needs-triage Status: A bug report needs triage
Projects
Zebra
Archived in project
Milestone
No milestone
2 participants
@mpguerra @teor2345