Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(consensus): Lower mandatory checkpoint height #8629

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Jun 20, 2024

Motivation

We want to support full validation of blocks from Canopy activation onwards, particularly for full validation of Canopy blocks on Regtest (though this use case also relies on supporting block construction for Canopy blocks).

Closes #8430.

Specifications & References

https://zips.z.cash/zip-0212

Solution

Lowers mandatory checkpoint height to the block before Canopy activation.

Tests

The mandatory checkpoint height test was updated to expect the last pre-Canopy block height.

Running a sync test locally with checkpoint sync disabled and an added checkpoint at height 1_046_399 until it gets past the grace period

Follow-up Work

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 added A-consensus Area: Consensus rule updates P-Low ❄️ labels Jun 20, 2024
@arya2 arya2 self-assigned this Jun 20, 2024
@arya2 arya2 marked this pull request as ready for review June 20, 2024 00:02
@arya2 arya2 requested a review from a team as a code owner June 20, 2024 00:02
@arya2 arya2 requested review from upbqdn and removed request for a team June 20, 2024 00:02
@arya2
Copy link
Contributor Author

arya2 commented Jun 20, 2024

The sync test with checkpoint sync disabled passed the end of the grace period.

upbqdn
upbqdn previously approved these changes Jun 26, 2024
zebra-chain/src/parameters/network/tests/prop.rs Outdated Show resolved Hide resolved
zebra-chain/src/parameters/network/tests/prop.rs Outdated Show resolved Hide resolved
zebra-chain/src/parameters/network/tests/prop.rs Outdated Show resolved Hide resolved
zebra-chain/src/parameters/network.rs Outdated Show resolved Hide resolved
mergify bot added a commit that referenced this pull request Jun 26, 2024
Co-authored-by: Marek <mail@marek.onl>
mergify bot added a commit that referenced this pull request Jun 27, 2024
@mergify mergify bot merged commit 549a7bb into main Jun 27, 2024
131 of 132 checks passed
@mergify mergify bot deleted the lower-mandatory-checkpoint-height branch June 27, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates P-Low ❄️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add semantic block validation during the ZIP-212 grace period after Canopy activation
2 participants