Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(actions): remove warnings related to gcp and docker steps #8750

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

gustavovalverde
Copy link
Member

@gustavovalverde gustavovalverde commented Aug 8, 2024

Motivation

Having warnings that are not helpful in our workflows summaries, makes warning that we should care about less relevant or harder to find.

image

Solution

  • Remove deprecated arguments
  • Deactivate Docker summary (not supported by Docker Build Cloud, yet)
    • Use a variable DOCKER_BUILD_SUMMARY and set it to false, as this feature might be available in the future

Follow-up Work

I also tried solving this warning:

  • Unable to extend GITHUB_TOKEN expiration time due to: GITHUB_TOKEN has expired.

But it seems we won't be able to do it, based on this discussion:

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

@gustavovalverde gustavovalverde added A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup I-usability Zebra is hard to understand or use P-Medium ⚡ labels Aug 8, 2024
@gustavovalverde gustavovalverde self-assigned this Aug 8, 2024
@gustavovalverde gustavovalverde requested a review from a team as a code owner August 8, 2024 20:32
@gustavovalverde gustavovalverde requested review from arya2 and removed request for a team August 8, 2024 20:32
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Aug 8, 2024
mpguerra
mpguerra previously approved these changes Aug 9, 2024
Copy link
Contributor

@mpguerra mpguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I just have some questions to try to understand the changes.

.github/workflows/ci-test-librustzcash.yml Outdated Show resolved Hide resolved
.github/workflows/cd-deploy-nodes-gcp.yml Show resolved Hide resolved
.github/workflows/sub-build-docker-image.yml Show resolved Hide resolved
@upbqdn upbqdn self-requested a review August 9, 2024 14:58
@gustavovalverde
Copy link
Member Author

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Aug 12, 2024

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Aug 12, 2024
@mergify mergify bot merged commit 6a4c47e into main Aug 12, 2024
148 of 149 checks passed
@mergify mergify bot deleted the remove-workflow-warnings branch August 12, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge I-usability Zebra is hard to understand or use P-Medium ⚡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants