-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(actions): remove warnings related to gcp and docker steps #8750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavovalverde
added
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-cleanup
Category: This is a cleanup
I-usability
Zebra is hard to understand or use
P-Medium ⚡
labels
Aug 8, 2024
github-actions
bot
added
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
extra-reviews
This PR needs at least 2 reviews to merge
labels
Aug 8, 2024
mpguerra
previously approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I just have some questions to try to understand the changes.
gustavovalverde
force-pushed
the
remove-workflow-warnings
branch
from
August 9, 2024 14:59
7806478
to
ccb491a
Compare
upbqdn
approved these changes
Aug 9, 2024
@Mergifyio refresh |
✅ Pull request refreshed |
mpguerra
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-cleanup
Category: This is a cleanup
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
extra-reviews
This PR needs at least 2 reviews to merge
I-usability
Zebra is hard to understand or use
P-Medium ⚡
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Having warnings that are not helpful in our workflows summaries, makes warning that we should care about less relevant or harder to find.
Solution
DOCKER_BUILD_SUMMARY
and set it to false, as this feature might be available in the futureFollow-up Work
I also tried solving this warning:
Unable to extend GITHUB_TOKEN expiration time due to: GITHUB_TOKEN has expired.
But it seems we won't be able to do it, based on this discussion:
PR Author's Checklist