Add time_from_start information to feedback topic #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -163,6 +163,8 @@ class FollowJointTrajectoryController : public Controller | |||
| double goal_time_tolerance_; | |||
|
|
|||
| control_msgs::FollowJointTrajectoryFeedback feedback_; | |||
| control_msgs::FollowJointTrajectoryGoal goal_; | |||
There was a problem hiding this comment.
to avoid confusion (since you're only using the timestamp portion of this), I would suggesting using a ros::Time instance rather than a whole goal instance.
708yamaguchi
force-pushed
the
time-from-start
branch
from
9132af9
to
406f69d
Compare
|
@mikeferguson |
708yamaguchi
force-pushed
the
time-from-start
branch
from
406f69d
to
c2b68e2
Compare
708yamaguchi
force-pushed
the
time-from-start
branch
from
c2b68e2
to
0d6703d
Compare
|
@mikeferguson |
|
I don’t have merge rights, since I’m no longer with Fetch Robotics. |
|
I did not know that. |
|
@708yamaguchi can we get an equivalent PR into the melodic branch as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I used fetch with
follow joint trajectory, I found/*_controller/follow_joint_trajectory/feedbacktopic do not havetime_from_startinformation, so I addedtime_from_startto this topic.CC @pazeshun, @k-okada