Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZON-6179: first stab at the spec for search #23

Merged
merged 3 commits into from
Oct 8, 2020
Merged

ZON-6179: first stab at the spec for search #23

merged 3 commits into from
Oct 8, 2020

Conversation

tomster
Copy link
Member

@tomster tomster commented Oct 7, 2020

No description provided.

@tomster tomster changed the title ZON-6179: first stab at the spec for search [WIP] ZON-6179: first stab at the spec for search Oct 7, 2020
tomster
tomster commented Oct 8, 2020
View reviewed changes
api.yaml
items:
type: array
items:
$ref: "#/components/schemas/CenterpageRegion"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macht das Sinn, hier wie bei /cp/ eine CenterpageRegion zurueckzugeben? bei den Suchergebnissen gibt es ja keine unterschiedlichen Regionen - oder ist das dem Umstand geschuldet, dass wir evtl. einfach immer grundsaetzlich region -> area -> items ausliefern wollen?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

letzteres

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zur Info, prepublic hat sich jetzt doch das Gegenteil gewünscht - nur die Teaser gleich in items. Siehe #24

wosc
wosc reviewed Oct 8, 2020
View reviewed changes
Copy link
Member

@wosc wosc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reicht der App ein einfaches "query string"? Oder will die auch die Sortierungs- und Filterungsoptionen haben, die auf www.zeit.de/suche angeboten werden (siehe https://github.com/zeitonline/zeit.web/blob/master/src/zeit/web/site/module/search_form.py)?

@TStrothjohann
Copy link
Contributor

@wosc aktuell reicht der App laut Design-Prototyp der einfache query string. Da sind keine Filter vorgesehen...

@TStrothjohann
Copy link
Contributor

👍

@tomster tomster merged commit 7f7c315 into master Oct 8, 2020
@tomster tomster deleted the ZON-6179-search branch October 8, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wosc wosc wosc left review comments

@mstoltenburg mstoltenburg mstoltenburg left review comments

@TStrothjohann TStrothjohann TStrothjohann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomster @TStrothjohann @wosc @mstoltenburg