WCM-271: Basic mechanics for gradually moving metadata into individual columns #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wosc
force-pushed
the
WCM-271-column-mechanics
branch
6 times, most recently
from
a0ac5a0
to
e28907c
Compare
We need to differentiate properties that already have been migrated to columns from those that still remain in unsorted, for the transition period. And we can only determine this information via ns+name, especially in the `toProperty` case (in `fromProperty` we might have annotated the value returned by connector, or something).
Since we base Resource.type on properties[meta:type] anyway, put the heuristics for meta:type in get_properties, instead of bolting them on afterwards.
…/timestamp) We treat SQL connector as the new default, and update filesystem/mock to behave similarly
wosc
force-pushed
the
WCM-271-column-mechanics
branch
from
e28907c
to
1040574
Compare
louika
reviewed
Aug 13, 2024
| for column in self._columns_with_name(): | ||
| namespace, name = column.info['namespace'], column.info['name'] | ||
| value = props.get((name, self.NS + namespace), self) | ||
| if value is not self: |
There was a problem hiding this comment.
warum genau haben wir self als default gewählt? also anstatt None?
There was a problem hiding this comment.
Weil None als Wert grundsätzlich möglich ist. self als Marker für "war nicht im dict" zu nehmen ist so ein Python-"Trick", man könnte das Ganze natürlich auch mit if key in properties:... aufschreiben statt mit get(), oder mit einem expliziten MISSING = object() Marker, oder oder oder.
louika
reviewed
Aug 13, 2024
| resource = self.repository.connector['http://xml.zeit.de/testcontent'] | ||
| self.assertIs( | ||
| True, resource.properties[('overscrolling', 'http://namespaces.zeit.de/CMS/document')] | ||
| ) |
There was a problem hiding this comment.
wir haben auch eine Unicode Property umgezogen, theoretisch fehlt dafür ein ConvertTest. Auch wenns implizit in PropertiesColumnTest mit getestet wird.
louika
reviewed
Aug 13, 2024
| bases=(zeit.cms.testing.CONFIG_LAYER, SQL_CONFIG_LAYER), | ||
| ) | ||
| SQL_CONTENT_ZOPE_LAYER = zeit.cms.testing.ZopeLayer(bases=(SQL_CONTENT_ZCML_LAYER,)) | ||
| SQL_CONTENT_LAYER = SQLDatabaseLayer(bases=(SQL_CONTENT_ZOPE_LAYER,)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.