Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump p256 to 0.11 #168

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Bump p256 to 0.11 #168

merged 4 commits into from
Aug 22, 2022

Conversation

Be-P
Copy link
Contributor

@Be-P Be-P commented Jul 22, 2022

I've bumped the p256 dependency to version 0.11.1 and fixed some compilation issues. See #166

@tmpfs
Copy link
Contributor

tmpfs commented Aug 13, 2022 •
edited

Please can we land this I want to use the latest version of p256 in dependents and this is blocking me updating as compilation fails with conflicts on ecdsa-core.

Any help much appreciated as always 🙏

Edit: I am using the workaround in #166 for now - thanks @Be-P 👍

@shekohex
Copy link

Please can we land this I want to use the latest version of p256 in dependents and this is blocking me updating as compilation fails with conflicts on ecdsa-core.

Any help much appreciated as always 🙏

Edit: I am using the workaround in #166 for now - thanks @Be-P 👍

Same issue here! Hey @survived, any chance we can have this PR get merged and a new version get published?

elichai
elichai reviewed Aug 16, 2022
View reviewed changes
src/elliptic/curves/p256.rs Outdated
}
}

fn is_zero(&self) -> bool {
bool::from(self.fe.is_zero())
*self.fe == Scalar::ZERO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you replace this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tought it wasn't working, sorry, my bad

@Be-P
Copy link
Contributor Author

Be-P commented Aug 20, 2022 •
edited

@elichai I've fixed the cargofmt step. The next step that runs cargo clippy -- -D clippy::all, throws errors from various files that were not touched by this PR. Should I go around fixing them?

@elichai
Copy link
Contributor

elichai commented Aug 22, 2022

No need, I'll do that in a separate PR

@elichai elichai merged commit daebb16 into ZenGo-X:master Aug 22, 2022
@vnermolaev
Copy link

vnermolaev commented Sep 8, 2022 •
edited

maintainers, don't you think the crate deserves a version bump to 0.9.1 or something?
The problem addressed by this PR still exists for

curv-kzen = "0.9.0"
dsa = "0.4.0"

but does not for

curv-kzen = { git ="https://github.com/ZenGo-X/curv.git" }
dsa = "0.4.0"

glitch003 pushed a commit to LIT-Protocol/curv that referenced this pull request Sep 21, 2022
@Be-P @elichai @glitch003
Bump p256 to 0.11 (ZenGo-X#168)
edc11bf 
* first fixes, change dependency version

* fix compilation issues

* rustfmt and revert small change in p256

* cargo fmt

Co-authored-by: Elichai Turkel <elichai.turkel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elichai elichai elichai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Be-P @tmpfs @shekohex @elichai @vnermolaev