Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the CLI to use the new "docker compose" #16

Closed
asishallab opened this issue May 22, 2023 · 0 comments · Fixed by #35
Closed

Switch the CLI to use the new "docker compose" #16

asishallab opened this issue May 22, 2023 · 0 comments · Fixed by #35
Assignees
Labels
bug Something isn't working

Comments

@asishallab
Copy link
Member

asishallab commented May 22, 2023

For those who remember: "Raider heißt jetzt Twix, sonst ändert sich nix."

Fix the CLI

Installing latest Docker now comes with a "Docker plugin".
So instead of using docker-compose with a "-" we now need to use docker compose
without a "-".

Please provide comprehensive error messages in case the CLI does not find tools it expects to be present, like e.g. docker compose (without the dash).

Fix integration tests

So, we need to fix integration tests, probably, too. Search the code base with e.g. ripgrep recursively for docker-compose and thus find the places where we need to fix this issue, too.

Guidelines

Please fix in a separate branch, test, and provide a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants