-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
building only on approval saves us some cpu - do not merge #133
base: main
Are you sure you want to change the base?
Conversation
Looked at this even though it's assigned to @zenenock, it looks good. |
Turns out this isn't as easy as I had hoped.
Only works for you on the approve event, you can't access Also - the reference |
Ideally images are buildable before merging - but building on every commit to a PR is too expensive.
What we do now, is wait until a PR is approved before building it.
This way branch rules can be kept in place (must be built before merging) and don't waste cycles building on each commit.