Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATI/Intel Compatibility "Automatic" setting is too aggressive #843

Open
completesomething opened this issue Feb 25, 2023 · 3 comments
Open

Comments

@completesomething
Copy link

completesomething commented Feb 25, 2023

Right now having ATI/Intel Compatibility set to "Automatic" excludes any AMD card from the setting of /water 4 (bumpmapped water) on game start.

https://github.com/ZeroK-RTS/Chobby/blob/master/LuaMenu/configs/gameConfig/zk/settingsMenu.lua#L301
Source commit: b4b24b5

As a result of this, a significant portion of the userbase could be using unideal water settings without even realizing it.

Possible solutions:

  • Make the checks smarter.
  • Disable ATI/Intel Compatibility by default.
@GoogleFrog
Copy link

GoogleFrog commented Feb 26, 2023

Is water 4 supported on ATI/Intel? When I last heard from engine devs it wasn't, and they wouldn't fix bug reports about it. But there are different engine devs now so it could be worth looking into again. Do you know of people who are using water 4 successfully?

@Porkch0p
Copy link

Recent statement and discussion with engine devs on water 0/1/4: https://discord.com/channels/278805140708786177/911790552687730689/1078153054391648316

Personal Testing with AMD/Linux

  • Water 1 looks invisible (this is the automatic setting)
  • Water 4 looks good, but ATI/Intel Compatibility set to Automatic overrides it with /water 1.
  • Water 0 isn't fancy, but still looks like water.

Pics of Water on Adansonia

Is this also how water appears on Windows for AMD graphics? If so, it seems like either option would be an improvement, and if only 0 and 4 are supported by engine, 0 may be the better automatic fallback for Intel (untested).

@GoogleFrog
Copy link

I guess that means water 4 works for some ATI? But we need to be able to tell which ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants