Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theater.play() and theater.stop() issue #49

Closed
AmineI opened this issue Mar 9, 2016 · 6 comments
Closed

theater.play() and theater.stop() issue #49

AmineI opened this issue Mar 9, 2016 · 6 comments
Labels

Comments

@AmineI
Copy link

AmineI commented Mar 9, 2016

Hello again ! I've been playing a lot with your awesome javascript, and i found an issue in one of the core features.
When you assign the theater.play() and theater.stop() toggles on a button, pressing it multiple times button within a certain amount of time (before the current scene/event stops) make Theater completely buggy, a fiddle will explain it better than me :

https://jsfiddle.net/AmineIzumi/yexw3do1/3/

(I also found a workaround, which is simply binding the toggle to the typing:end event)

@zhouzi
Copy link
Owner

zhouzi commented Mar 9, 2016

Thanks for the heads-up! That's definitely a bug so I'll have a look ;)

@zhouzi zhouzi added the bug label Mar 9, 2016
@zhouzi
Copy link
Owner

zhouzi commented Mar 13, 2016

So I figured out the issue and it's now fixed per 10d4152 ;)

@zhouzi zhouzi closed this as completed Mar 13, 2016
@AmineI
Copy link
Author

AmineI commented Mar 13, 2016

Thanks ! The fact that the fix is working locally but not in the fiddle (which use the CDN version) tells me that the CDN isn't up to date, or that the 2.0.2 isn't the 'latest' release for the CDN (which appears to be the case in the release tab of Github). Could you update the CDN to 2.0.2 as well :) ?

Edit : The CDN isn't considering the 2.0.2 as the 'latest' release, like i suggested. A workaround is to use the url //cdn.jsdelivr.net/theaterjs/2.0.2/theater.min.js instead of //cdn.jsdelivr.net/theaterjs/latest/theater.min.js

@zhouzi
Copy link
Owner

zhouzi commented Mar 13, 2016

Thanks for looking into it, /latest is probably cached on your side. Emptying it should make the latest version appear (it worked for me and /latest is 2.0.2). Let me know if it's still not working ;)

@AmineI
Copy link
Author

AmineI commented Mar 13, 2016

You're right, i didn't thought about that :o ! However, what about Github Releases showing 2.0.1 as "latest release" ?

@zhouzi
Copy link
Owner

zhouzi commented Mar 13, 2016

Oh that's weird, I've added the v2.0.2 git tag but didn't use GitHub's ui to release it, that's probably why. I'll go through GitHub's documentation to learn more about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants
@zhouzi @AmineI and others