-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
theater.play() and theater.stop() issue #49
Comments
Thanks for the heads-up! That's definitely a bug so I'll have a look ;) |
So I figured out the issue and it's now fixed per 10d4152 ;) |
Thanks ! The fact that the fix is working locally but not in the fiddle (which use the CDN version) tells me that the CDN isn't up to date, or that the 2.0.2 isn't the 'latest' release for the CDN (which appears to be the case in the release tab of Github). Could you update the CDN to 2.0.2 as well :) ? Edit : The CDN isn't considering the 2.0.2 as the 'latest' release, like i suggested. A workaround is to use the url |
Thanks for looking into it, /latest is probably cached on your side. Emptying it should make the latest version appear (it worked for me and /latest is 2.0.2). Let me know if it's still not working ;) |
You're right, i didn't thought about that :o ! However, what about Github Releases showing 2.0.1 as "latest release" ? |
Oh that's weird, I've added the |
Hello again ! I've been playing a lot with your awesome javascript, and i found an issue in one of the core features.
When you assign the theater.play() and theater.stop() toggles on a button, pressing it multiple times button within a certain amount of time (before the current scene/event stops) make Theater completely buggy, a fiddle will explain it better than me :
https://jsfiddle.net/AmineIzumi/yexw3do1/3/
(I also found a workaround, which is simply binding the toggle to the typing:end event)
The text was updated successfully, but these errors were encountered: