-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
confirmStopRecording does not work with Android Hardware Back Button #30
Comments
Hi @sagrawal31, Regarding the confirmation when back button is pressed - I'll add this feature. |
Thank you @3akat I hope that will not take much of your time as you will have to probably reuse your existing code. By the way, by when can we expect this? |
Plan to release this tomorrow. |
So relieved to see your reply 👍 |
Hi @sagrawal31! Please take a look at |
Hi, @3akat thank you for releasing the new version. I'll try that out. Regarding the rest two buttons, we have already handled it by pinning the app using Android pin feature 😄Thank you for pointing it out explicitly. |
Hi, @3akat I tested the release Basically, setting
But conceptually, Also, what if we don't need the first button i.e. we can't allow our user to review their recording and re-record the option. So is there a way we can hide the first button and keep showing the 2nd button when |
Hi @3akat let me know if I should create a separate issue for the above? |
Hi @sagrawal31, |
Actually, I noticed a potential UX issue after this issue was fixed. Basically, in both the cases, when either the hardware back button is pressed or checkmark button is pressed, the message is Are you sure want to stop recording? which is shown in the confirmation dialogue. But the actions of both the dialogues are different.
Of course, the actions are correct but the message is very confusing. |
Can we reopen this issue to discuss? |
Thank you for commenting on this. It can be a bit confusing in such case. Unless my colleague thinks or suggests otherwise, we could:
In such case there would not be any difference in the actions they do, just the way it is messaged back to the person doing the recording. Shashank I think these would do nicely however since you reported it happy to hear your suggestion :) |
I agree with you on the texts @Bane-D Yes, action will be the same. |
@Bane-D would you mind reopening the issue? So that this can be scheduled. |
Good idea, will implement. |
Apologies, if I'm creating so many issues 😞 but I was hoping that the issues that I'm creating should not be there.
Basically, in Android, when recording is started, a student (primary user of our app) might accidentally press the hardware back button. When we encountered the issue, I went looking for the configuration and the doc and found out the method
confirmStopRecording(true)
.Unfortunately, this shows the confirmation dialogue only for "Stop button" or "Send & Close" checkmark but not when the back button is pressed.
I think this is a very important point when it comes to recorder because the probability of pressing the back button is very high and we can't allow the recorder to be immediately closed without confirmation.
Please let me know how to handle this scenario?
The text was updated successfully, but these errors were encountered: