add OpenCBM ports #1
Conversation
Zirias
commented
Jun 1, 2020
Zirias
commented
- master comms/opencbm (main program, xu1541 and xum1541 plugins)
- slave comms/opencbm-plugin-xa1541 (plugin for parallel port cable)
- slave comms/opencbm-kmod (kernel driver for parallel port cable)
comms/opencbm/Makefile
Outdated
| 073b833772e4325c7f680d6aeb81bc11844f03ca.diff \ | ||
| 3e967551e200d0c03aa4898e482626a7510acd21.diff | ||
|
|
||
| OCBM_LICENSE= GPLv2+ |
There was a problem hiding this comment.
How do you know it's gplv2+, all I can find is https://github.com/OpenCBM/OpenCBM/blob/master/opencbm/COPYING and https://github.com/OpenCBM/OpenCBM/blob/master/opencbm/mBSD-License.txt
You can list the license file with LICENSE_FILE= ${WRKSRC}/xxx
There was a problem hiding this comment.
It's in the source file of the driver module itself ( in sys/freebsd/ ) -- should a source file be added as a license file?
|
Regarding the overall comment, I think I might reorganize it to not really be master/slave as there's probably too little shared, but maybe use some shared make includes instead. Thanks for reviewing, indeed missed a few things :) |
* master comms/opencbm (main program, xu1541 and xum1541 plugins) * slave comms/opencbm-plugin-xa1541 (plugin for parallel port cable) * slave comms/opencbm-kmod (kernel driver for parallel port cable)
* share only a Makefile.inc and distinfo file * resolve hardcoded /usr/local by patching with sed from Makefile
| USES= gmake | ||
| USE_LDCONFIG= yes | ||
|
|
||
| MAKE_ARGS= CC=cc SUBDIRS_PLUGIN_XA1541=opencbm/lib/plugin/xa1541 |
| OPTIONS_DEFINE= DOCS INFO | ||
| OPTIONS_DEFAULT= DOCS INFO | ||
|
|
||
| MAKE_ARGS= CC=cc INFODIR=${PREFIX}/share/info |
There was a problem hiding this comment.
CC="${CC}" INFODIR=${PREFIX}/${INFO_PATH}
| @${REINPLACE_CMD} -e 's|_ETC="$$1"|_ETC="$${1:-${LOCALBASE}/etc}"|' \ | ||
| -e 's|in /.*/ instead|in ${OCBM_CONFDIR}/ instead|' \ | ||
| -e "s|execute 'opencbm_|execute '|" \ | ||
| ${WRKSRC}/opencbm/LINUX/plugin_helper_tools |
There was a problem hiding this comment.
Use patch files whenever possible porters handbook 4.4.3. Simple Automatic Replacements)
There was a problem hiding this comment.
Not possible here, as this must patch in the value of LOCALBASE, to avoid hardcoding /usr/local in a patch file
| post-install: | ||
| ${STRIP_CMD} ${STAGEDIR}${PLUGINBASENAME}xa1541.so.${OCBM_LIBVERSION} | ||
| @${RM} ${STAGEDIR}${PREFIX}/etc/opencbm.conf.d/00opencbm.conf | ||
| @${RM} ${STAGEDIR}${PREFIX}/etc/opencbm.conf |
|
Thanks for noticing the errors with hardcoded |
