Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: to not call storage.estimate if it's not supported #136

Merged
merged 1 commit into from
Aug 10, 2020
Merged

fix: to not call storage.estimate if it's not supported #136

merged 1 commit into from
Aug 10, 2020

Conversation

glebv
Copy link
Contributor

@glebv glebv commented Aug 6, 2020

Closes #135

@Zizzamia Zizzamia changed the title fix(perfume): to not call storage.estimate if it's not supported fix: to not call storage.estimate if it's not supported Aug 10, 2020
Zizzamia
Zizzamia approved these changes Aug 10, 2020
View reviewed changes
Copy link
Owner

@Zizzamia Zizzamia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌲🚀🌕

@Zizzamia Zizzamia merged commit 2db4fda into Zizzamia:master Aug 10, 2020
@Zizzamia
Copy link
Owner

@glebv thank you again for your contribution. I just released v5.1.1 which includes your fix. 🔥

@glebv
Copy link
Contributor Author

glebv commented Aug 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zizzamia Zizzamia Zizzamia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'storage.estimate' is not a function
2 participants
@glebv @Zizzamia