fix: restore UMD module breaking #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extreme minification removes even the ".Perfume=" part that is essential to get the UMD module working if loaded from a CDN. Without this fix, `Perfume` is `undefined` in a page that loads the UMD version through a CDN.
|
Amazing, thank you @NoriSte for such a quick response 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: The extreme minification removes even the ".Perfume=" part that is essential to get the UMD module working if loaded from a CDN. Without this fix,
Perfumeisundefinedin a page that loads the UMD version through a CDN.My Perfume.js for Gatsby plugin cannot update Perfume.js to the latest version. That's because of a failing test, the one that checks that Perfume.js could be consumed through Unpkg (instead of installing/importing in the local project). Here the option and here the option management.
The test fails because the previous version(line 1, column 155) has a
Perfume=code that it is disappeared in the new version (that makes the global scope "dirty" with atvariable).@Zizzamia suggested me how to solve it, I have tested it locally and I can confirm that everything works with this change.
This way I could update my Gatsby plugin to leverage the latest Perfume.js version 😊