Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Protobuf Dependency #227

Closed
lmuntaner opened this issue Feb 27, 2024 · 2 comments · Fixed by #228
Closed

Remove Protobuf Dependency #227

lmuntaner opened this issue Feb 27, 2024 · 2 comments · Fixed by #228

Comments

@lmuntaner
Copy link

lmuntaner commented Feb 27, 2024

We announced in the Forum that the NNS dapp will remove the protobuf dependency.

We would like to do the same in the IC app of the Ledger.

Could you prepare a release without any of the protobuf code?

I would appreciate it if there could be extra checks to make sure we didn't forget any support for Candid. Could you give us the list of transactions that are not supported in Candid. As far as I know, only Merge Maturity should not be supported because it was deprecated.

Thanks!

🔗 zboto Link

@neithanmo
Copy link
Collaborator

@lmuntaner
current candid transactions supported by the ledger application:

  • candid_manageneuron
  • candid_listneurons
  • candid_updatenodeprovider
  • candid_transfer
  • candid_icrc_transfer

the supported pb transactions that would be removed:

  • send_request
  • manage_neuron
  • list_neurons
  • claim_neurons

we could remove protobuf support or maybe add a compilation flag todisable/enable it.

@ainhoa-a
Copy link
Member

We will remove protobuf support. No need to consider a solution with a flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants