Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry timed out requests to support poorly characterized non-real-time networks #17

Closed
pavel-kirienko opened this issue Sep 5, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@pavel-kirienko
Copy link
Member

One is unlikely to encounter packet loss if the network is well-designed, but developers often have to deal with overloaded networks where the timing guarantees expected by Cyphal are not upheld.

Extend the FileLocationSpecifier with the number of requests made:

struct FileLocationSpecifier
{
std::uint8_t local_node_index{};
NodeID server_node_id{};
std::size_t path_length{};
std::array<std::uint8_t, dsdl::File::PathCapacity> path{};
std::optional<std::chrono::microseconds> response_deadline{};
};

@pavel-kirienko pavel-kirienko added enhancement New feature or request help wanted Extra attention is needed labels Sep 5, 2022
pavel-kirienko added a commit that referenced this issue Sep 5, 2022
pavel-kirienko added a commit that referenced this issue Sep 5, 2022
- Provide dedicated parameter struct to minimize usage errors.
- Retry timed out requests up to a configurable number of times (#17).
@pavel-kirienko
Copy link
Member Author

Done in #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant