Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Not allowing to create a new workspace with name containing spaces #940

Closed
GuillaumeFalourd opened this issue May 27, 2021 · 0 comments · Fixed by #977
Closed

Not allowing to create a new workspace with name containing spaces #940

GuillaumeFalourd opened this issue May 27, 2021 · 0 comments · Fixed by #977
Assignees
@lucasdittrichzup
Labels
📚 documentation Improvements or additions to documentation good first issue Good for newcomers 🔨 improvement Improvement in features ✔️ refined ISSUE refined by the Ritchie Team priority:high High priority level of an issue

Comments

@GuillaumeFalourd
Copy link
Contributor

GuillaumeFalourd commented May 27, 2021 •
edited
Loading

What would you like to be added

  • Workspaces' names can't contain any space, otherwise this might lead to some problem when using the generated docker-image executing formulas from the workspace with Docker (--docker)

Demonstration

Screen Shot 2021-05-27 at 15 08 39

Why is this needed

This behaviour is not expected when using Docker, and it would be great to inform the user when adding the workspace's name that it is incorrect, or that it will be updated to a correct format.

Note: It could be interesting not allowing other special character incompatible with Docker as well.
@GuillaumeFalourd GuillaumeFalourd added priority:high High priority level of an issue 🔨 improvement Improvement in features ✔️ refined ISSUE refined by the Ritchie Team labels May 27, 2021
@GuillaumeFalourd GuillaumeFalourd added the good first issue Good for newcomers label Jun 2, 2021
@lucasdittrichzup lucasdittrichzup self-assigned this Jun 11, 2021
@lucasdittrichzup lucasdittrichzup added the 📚 documentation Improvements or additions to documentation label Jun 29, 2021
@ritchieservicezup ritchieservicezup mentioned this issue Jun 29, 2021
Closed
@lucasdittrichzup lucasdittrichzup mentioned this issue Jun 29, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lucasdittrichzup lucasdittrichzup

Labels
📚 documentation Improvements or additions to documentation good first issue Good for newcomers 🔨 improvement Improvement in features ✔️ refined ISSUE refined by the Ritchie Team priority:high High priority level of an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: validate workspace name lucasdittrichzup/ritchie-cli
2 participants
@GuillaumeFalourd @lucasdittrichzup