Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The f64 -> int serialization has broken determinism #689

Closed
dabreegster opened this issue Jul 3, 2021 · 1 comment
Closed

The f64 -> int serialization has broken determinism #689

dabreegster opened this issue Jul 3, 2021 · 1 comment
Labels
🔥 🔥 🔥 priority Major user-facing issue

Comments

@dabreegster
Copy link
Collaborator

#686 gave us some great file size savings, but I've hit a few unexpected problems since then: 137e9a0 and 9f4fac5. And now I have a case where running from a simulation savestate crashes with a queue overflow (by Distance(-0.0001)), but it runs fine without the serialization/deserialization round-trip.

I thought the change was safe; the conversion to/from ints should be lossless. But it looks like the f64 trimming must not work the way I expect.

Options:

  • Dig into why the f64 trimming isn't actually working
  • Revert these commits and go back to f64s
  • Change the in-memory representation of the geom types to be integers
@dabreegster dabreegster added the 🔥 🔥 🔥 priority Major user-facing issue label Jul 3, 2021
@dabreegster
Copy link
Collaborator Author

Closed by 1063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 🔥 🔥 priority Major user-facing issue
Projects
None yet
Development

No branches or pull requests

1 participant